8064 - assertion in XIF code

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[buster]

In viewer, when I try one of my HTML form tests at:
Click on one of the tests at this URL.  I tried windows-1250
(http://warp/employees/erik/tests/forms/nbsp/all-charsets/windows-1250.cgi)

I get the following stack trace:

NTDLL! 77f76148()
nsDebug::Assertion(char * 0x005bd224, char * 0x005bd208, char *
0x005bd1d4, int 476) line 150 + 13 bytes
nsHTMLToTXTSinkStream::EncodeToBuffer(const nsString & {...}) line 476 +
35 bytes
nsHTMLToTXTSinkStream::AddLeaf(nsHTMLToTXTSinkStream * const 0x012675d0,
const nsIParserNode & {...}) line 677
nsXIFDTD::ProcessEntityTag(const nsIParserNode & {...}) line 1670 + 31
bytes
nsXIFDTD::HandleStartToken(CToken * 0x01140b50) line 673
XIFDispatchTokenHandler(CToken * 0x01140b50, nsIDTD * 0x01465ec8) line
265 + 12 bytes
CTokenHandler::operator()(CToken * 0x01140b50, nsIDTD * 0x01465ec8) line
80 + 14 bytes
nsXIFDTD::HandleToken(nsXIFDTD * const 0x01465ec8, CToken * 0x01140b50,
nsIParser * 0x01267470) line 535 + 18 bytes
nsXIFDTD::BuildModel(nsXIFDTD * const 0x01465ec8, nsIParser *
0x01267470, nsITokenizer * 0x01268290, nsITokenObserver * 0x00000000,
nsIContentSink * 0x012675d0) line 475 + 20 bytes
nsParser::BuildModel() line 902 + 34 bytes
nsParser::ResumeParse(nsIDTD * 0x00000000) line 849 + 11 bytes
nsParser::Parse(nsString & {...}, void * 0x00000000, const nsString &
{...}, int 0, int 1) line 733 + 13 bytes
nsTextEditor::OutputTextInternal(nsTextEditor * const 0x011deb40,
nsIOutputStream * 0x00000000, nsString * 0x0012f838, nsString *
0x00000000) line 1601 + 49 bytes
nsTextEditor::OutputTextToString(nsTextEditor * const 0x011deb74,
nsString & {...}) line 1545
nsGfxTextControlFrame::ContentChanged(nsGfxTextControlFrame * const
0x011de9e0) line 1203
nsEnderDocumentObserver::ContentChanged(nsEnderDocumentObserver * const
0x011deb10, nsIDocument * 0x01239400, nsIContent * 0x0126691c,
nsISupports * 0x00000000) line 1320 + 21 bytes
nsDocument::ContentChanged(nsDocument * const 0x01239400, nsIContent *
0x0126691c, nsISupports * 0x00000000) line 1509
nsGenericDOMDataNode::ReplaceData(unsigned int 0, unsigned int 0, const
nsString & {...}) line 354
nsGenericDOMDataNode::InsertData(unsigned int 0, const nsString & {...})
line 298
nsTextNode::InsertData(nsTextNode * const 0x01266910, unsigned int 0,
const nsString & {...}) line 51 + 22 bytes
InsertTextTxn::Do(InsertTextTxn * const 0x0126c800) line 73 + 40 bytes
nsTransactionItem::Do() line 102 + 18 bytes
nsTransactionManager::BeginTransaction(nsITransaction * 0x0126c800) line
1038 + 11 bytes
nsTransactionManager::Do(nsTransactionManager * const 0x0126a910,
nsITransaction * 0x0126c800) line 134 + 18 bytes
nsEditor::Do(nsEditor * const 0x011deb40, nsITransaction * 0x0126c800)
line 868 + 30 bytes
nsEditor::DoInitialInsert(nsEditor * const 0x011deb40, const nsString &
{...}) line 1672 + 16 bytes
nsEditor::InsertText(nsEditor * const 0x011deb40, const nsString &
{...}) line 1517 + 19 bytes
nsTextEditor::InsertText(nsTextEditor * const 0x011deb40, const nsString
& {...}) line 1025 + 16 bytes
nsGfxTextControlFrame::InitializeTextControl(nsGfxTextControlFrame *
const 0x011de9e0, nsIPresShell * 0x01261120, nsIDOMDocument *
0x01239404) line 1132 + 42 bytes
nsGfxTextControlFrame::InstallEditor(nsGfxTextControlFrame * const
0x011de9e0) line 937 + 33 bytes
EnderTempObserver::OnStopBinding(EnderTempObserver * const 0x011dea80,
nsIURL * 0x011f0cc0, unsigned int 0, unsigned short * 0x011f2d20) line
1562
nsDocumentBindInfo::OnStopBinding(nsDocumentBindInfo * const 0x011f0f60,
nsIURL * 0x011f0cc0, unsigned int 0, unsigned short * 0x011f2d20) line
1549
OnStopBindingProxyEvent::HandleEvent(OnStopBindingProxyEvent * const
0x011f2cd0) line 593 + 45 bytes
StreamListenerProxyEvent::HandlePLEvent(PLEvent * 0x011f2cd4) line 473 +
12 bytes
PL_HandleEvent(PLEvent * 0x011f2cd4) line 491 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00ff1cf0) line 452 + 9 bytes
_md_EventReceiverProc(void * 0x01fe0506, unsigned int 49324, unsigned
int 0, long 16719088) line 868 + 9 bytes
USER32! 77e71250()

Comment 1

[buster]

please look at this for M7, if possible.  Thanks!

Comment 2

[Simon Fraser [no longer active]]

I was seeing this too, when playing with getting plain text output. It seems
harmless to continue past it (when using Latin 1, at least).

Comment 3

[Akkana Peck]

This is really a dup of 6748, but I'm going to keep it separate and make this
bug represent the fact that it's an assertion instead of the nonfatal NS_VERIFY
(I'll make that change for M7), and the other bug continue to be a reminder to
figure out whether it's really a bad thing not to have a unicode encoder there
in the first place (currently marked for M8).

Simon is correct that it's harmless to continue past it -- if there's no unicode
encoder it will simply copy the buffer and continue.

Comment 4

[Akkana Peck]

This is now an NS_VERIFY.  The other bug is still in place to determine whether
the NS_VERIFY needs to be there.

Comment 5

[sujay]

verified in 6/16 build.