806583 - strange white border around textboxes appeared since some time in gecko 18

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[:aceman]

Attachment: screenshot of bad textboxes

Strange white border is rendered around all textboxes since some time in gecko 18. It is seen in Thunderbird (self compiled) and also official Firefox Aurora 18 from mozilla.org. It is there since that time.
This problem also appeared once in the past around July 1 but vanished several days after that. Now it reappeared and stayed for some weeks.

See the screenshot.

This is on Slackware linux 14, 32bit. Libraries up to date (latest Thunderbird trunk can be compiled/run on it). Running in a KDE3 desktop.

Comment 1

[:aceman]

Last good nightly: 2012-09-28
First bad nightly: 2012-09-29

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=895f66c4eada&tochange=c09a0c022b2e

Found on Firefox nightlies with mozregression tool.

Comment 2

[:aceman]

I can build Thunderbird from comm-central so if you have any tips on which patches to try to revert I can do it (just tell me the hg commands:)).

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

No real idea what could be causing this.

Comment 4

[Karl Tomlinson (:karlt)]

What is the GTK theme?

Comment 5

[:aceman]

Not sure, how can I find it out?
I use KDE3, but this TB/FF is run under a user that has never started any desktop environment. I su to the user from an xterm. So it may not have the proper defaults set yet. Please tell me what to check.

Comment 6

[Karl Tomlinson (:karlt)]

Yeah, it's not necessarily trivial to find out.
Check ~/.gtkrc-2.0 and /etc/gtk-2.0/gtkrc for a gtk-theme-name setting.
Look in ~ for the user of the TB/FF process, but the GTK2_RC_FILES environment variable may contain more files to check for the setting, including the session user's files.
GTK also looks for an XSettings daemon which can provide the theme.  Some desktops provide this daemon and each would have a different way of controlling the setting, but I don't think KDE3 has an XSettings daemon.
Those are the mechanisms I know.  Perhaps there are more.

Comment 7

[:aceman]

There is no ~/.gtkrc-2.0 but /etc/gtk-2.0/gtkrc contains:
gtk-theme-name="GTK+"

No GTK2_RC_FILES environment variable, no XSettings daemon. This is KDE3 on Slackware 14.

Comment 8

[Karl Tomlinson (:karlt)]

Thanks.  I can reproduce with the built-in theme.

Comment 9

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1949b59f3d12&tochange=5f4c8635e87e

Comment 10

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9f476b4ac1e1&tochange=b5559af3cf94

The compile errors are getting less trivial to fix.

Comment 11

[Karl Tomlinson (:karlt)]

Reverting http://hg.mozilla.org/integration/mozilla-inbound/diff/1556064f1c20/widget/gtk2/nsNativeThemeGTK.cpp
restores intended behavior (even though I've come to like the white border).

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I suspect you'll get reftest failures if you revert that (since I think Matt added it to fix test failures)

Comment 13

[Karl Tomlinson (:karlt)]

Looks like the cause of reftest failures has been resolved elsewhere:
https://tbpl.mozilla.org/?tree=Try&rev=492b9d6d865d

Comment 14

[:aceman]

Confirming comment 11 fixes the problem on TB trunk.

Comment 15

[Karl Tomlinson (:karlt)]

Attachment: don't draw the entry background outside its widget

The changeset referenced in comment 11 shouldn't really have caused this bug, but this code was written assuming the clip_rect would never be larger than the entry widget's rect.

GtkEntry only sets this background on its own widget, so it doesn't make sense to draw outside the widget rect.

Comment 16

[Karl Tomlinson (:karlt)]

Attachment: remove unnecessary extra space added for textfield/entry

But it should not be necessary to draw extra space around a textfield/entry widget.  GtkEntry is implemented with its own window so it can never draw outside its bounds.  If our mimicking of GtkEntry is causing drawing outside the entry widget, then there is a bug somewhere else.

Comment 17

[Karl Tomlinson (:karlt)]

https://tbpl.mozilla.org/?tree=Try&rev=c3ef64b5e150

Comment 18

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29a7fc6e3930
https://hg.mozilla.org/integration/mozilla-inbound/rev/3523098f7911

I expect I can write a test to check that textboxes don't draw outside their bounds.

This bug should be affecting all themes that don't use Gecko's honors-transparent-bg-hint style property but our test machines might use that.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/29a7fc6e3930
https://hg.mozilla.org/mozilla-central/rev/3523098f7911

Comment 20

[bhavana bajaj [:bajaj]]

Tracking 18, DLBI regression .

Comment 21

[Karl Tomlinson (:karlt)]

The test that failed here didn't fail on the test machines, but I checked it in anyway.  I assume Fedora 12 defaults to Clearlooks, which sets honors-transparent-bg-hint.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b96d1860a248

Comment 22

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b96d1860a248

Comment 23

[:aceman]

Thanks, verified the fix in today's Thunderbird trunk.

We may want this in TB18 too.

Comment 24

[:aceman]

In Firefox 18 too of course. Please nominate the right patch for Aurora.

Comment 25

[Karl Tomlinson (:karlt)]

Comment on attachment 678611 [details] [diff] [review]
remove unnecessary extra space added for textfield/entry

We could take either patch as a fix on branch, but this is the one that restores the code to the state before the regression.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): dlbi
User impact if declined: extra white border with some GTK themes
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 26

[bhavana bajaj [:bajaj]]

Comment on attachment 678611 [details] [diff] [review]
remove unnecessary extra space added for textfield/entry

Approving the patch on aurora and adding "qawanted" , "verifyme" to help with verification here.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/93bd1c5aaca4
https://hg.mozilla.org/releases/mozilla-aurora/rev/c8166994bb80
https://hg.mozilla.org/releases/mozilla-aurora/rev/2b56eb204647
https://hg.mozilla.org/releases/mozilla-aurora/rev/1ddac35a4135

Comment 28

[:aceman]

Verified fix in Aurora:
Mozilla/5.0 (X11; Linux i686; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121114042011

Thanks a lot!

Comment 29

[Virgil Dicu [:virgil] [QA]]

Marking as verified for 18 based on comment 28.

aceman, could you verify this is ok in 19 as well? (can't reproduce on ubuntu).

Comment 30

[:aceman]

Yes, it is OK in Firefox Aurora 19 as downloaded from mozilla.org.

Comment 31

[Virgil Dicu [:virgil] [QA]]

Thanks.