Closed Bug 806618 Opened 11 years ago Closed 11 years ago

rewrite PR_NewLogModule calls to not generate static initializers

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19

People

(Reporter: froydnj, Assigned: froydnj)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

patch
156.69 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
followup
2.03 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
Ted mentioned wanting to turn logging on unconditionally everywhere.  I
objected because of the number of static initializers created by logging
modules.

Let's fix that.
Attached patch patch — — Splinter Review 
First cut, compiles for me on Linux.

There's a log of ugly things that really deserve their own cleanup; this
is a fairly mechanical translation.
Attachment #676390 - Flags: review?(ehsan)
Comment on attachment 676390 [details] [diff] [review]
patch

Review of attachment 676390 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if this builds!
Attachment #676390 - Flags: review?(ehsan) → review+
Assignee: nobody → nfroyd
https://hg.mozilla.org/mozilla-central/rev/0ba68f985391
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Attached patch followup — — Splinter Review 
Somehow missed this one while grepping around.
Attachment #679344 - Flags: review?(ehsan)
Attachment #679344 - Flags: review?(ehsan) → review+
You need to log in before you can comment on or make changes to this bug.