806618 - rewrite PR_NewLogModule calls to not generate static initializers

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nathan Froyd [:froydnj]]

Ted mentioned wanting to turn logging on unconditionally everywhere.  I
objected because of the number of static initializers created by logging
modules.

Let's fix that.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

First cut, compiles for me on Linux.

There's a log of ugly things that really deserve their own cleanup; this
is a fairly mechanical translation.

Comment 2

[(no longer active)]

Comment on attachment 676390 [details] [diff] [review]
patch

Review of attachment 676390 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if this builds!

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ba68f985391

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ba68f985391

Comment 5

[Nathan Froyd [:froydnj]]

Attachment: followup

Somehow missed this one while grepping around.

Comment 6

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fdcb6474f4b4

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fdcb6474f4b4