rewrite PR_NewLogModule calls to not generate static initializers

RESOLVED FIXED in mozilla19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Depends on: 1 bug)

unspecified
mozilla19
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Ted mentioned wanting to turn logging on unconditionally everywhere.  I
objected because of the number of static initializers created by logging
modules.

Let's fix that.
(Assignee)

Comment 1

6 years ago
Created attachment 676390 [details] [diff] [review]
patch

First cut, compiles for me on Linux.

There's a log of ugly things that really deserve their own cleanup; this
is a fairly mechanical translation.
Attachment #676390 - Flags: review?(ehsan)

Comment 2

6 years ago
Comment on attachment 676390 [details] [diff] [review]
patch

Review of attachment 676390 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if this builds!
Attachment #676390 - Flags: review?(ehsan) → review+
Assignee: nobody → nfroyd
https://hg.mozilla.org/mozilla-central/rev/0ba68f985391
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(Assignee)

Comment 5

6 years ago
Created attachment 679344 [details] [diff] [review]
followup

Somehow missed this one while grepping around.
Attachment #679344 - Flags: review?(ehsan)

Updated

6 years ago
Attachment #679344 - Flags: review?(ehsan) → review+
You need to log in before you can comment on or make changes to this bug.