Closed Bug 806619 Opened 12 years ago Closed 7 years ago

Use callback function for SessionParser

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bnicholson, Unassigned)

Details

From https://bugzilla.mozilla.org/show_bug.cgi?id=722661#c12:

> Comment on attachment 672135 [details] [diff] [review]
> Part 1: Factor out session JSON parsing into SessionParser
> 
> >diff --git a/mobile/android/base/AboutHomeContent.java.in b/mobile/android/base/AboutHomeContent.java.in
> 
> >+        new SessionParser() {
> 
> >+        }.parse(jsonString);
> 
> I assume "parse" is  blocking call? Maybe you should add an "onFinishRead"
> call and put the "more" code in that? Then in the future, we could possibly
> move the code entirely to the background? If you think it's something to
> consider, file a new bug.
No longer relevant, I think: The spiritual successor is the RecentTabsAdapter, which does its parsing on a separate thread.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.