80662 - Need DBM_CFLAGS

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[cls]

Or more precisely, I need a way to specify the location of the dbm headers to
NSS/coreconf from the Mozilla makefiles.  In mozilla, we have a hidden build
feature triggered by setting MOZ_TRACK_MODULE_DEPS=1 when running configure.  We
use this to keep track of our intermodule header dependencies within Mozilla. 
Some day, we'd like to turn it on by default but for now, it's just running on
the senna tinderbox.  When using this option, it causes the include files for a
particular module to be installed in $(DIST)/include/<module> instead of
$(DIST)/include/.  This means that the path that coreconf is using to find the
modules does not work.  This needs to be fixed before we can start compiling psm
on the tinderboxes (well, senna at least).

Comment 1

[Wan-Teh Chang]

The patch I attached to bug #81181
(http://bugzilla.mozilla.org/showattachment.cgi?attach_id=35550)
addresses this bug.  You can use the MOZILLA_INCLUDES makefile
variable to specify any -I flags to NSS/coreconf.

Comment 2

[Wan-Teh Chang]

I checked in my patch for bug #81181.

In mozilla/security/manager/Makefile.in, you can use the new
MOZILLA_INCLUDES make variable to specify any -I flags you want
to NSS/coreconf.

*** This bug has been marked as a duplicate of 81181 ***

Comment 3

[cls]

Reopening.  Although this can be fixed by using the MOZILLA_INCLUDES variable,
it's not fixed yet.  Reassigning to PSM team.

Comment 4

[cls]

Lovely 2 step reassign.

Comment 5

[Wan-Teh Chang]

Attachment: Let's just -I all possible include dirs and get it over with.

Comment 6

[cls]

r=cls

Comment 7

[Wan-Teh Chang]

Chris, we missed the mozilla0.9.1 checkin deadline last night.
Should we target this bug at mozilla0.9.2?

Comment 8

[cls]

I sent an approval request off to drivers.  It's a trivial fix with no impact on
the final product that lets our developers continue to build using a config that
checks for module dependencies while building with crypto.  

Comment 9

[Christopher Blizzard (:blizzard)]

a=blizzard for 0.9.1

Comment 10

[Wan-Teh Chang]

Patch is checked in.  Marked the bug fixed.

Comment 11

[John Unruh]

Verified per wtc's comment.