Closed Bug 806634 Opened 7 years ago Closed 7 years ago

Announcements: record browser launch in the correct place

Categories

(Firefox for Android :: General, defect, P1)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 19
Tracking Status
firefox18 --- fixed

People

(Reporter: rnewman, Assigned: rnewman)

References

()

Details

(Whiteboard: [snippets])

Attachments

(3 files, 1 obsolete file)

Follow-up from bug 793053.

We need to record Fennec's launch time when Fennec actually launches, not when it sends us a pref change intent, because we *ask* for a pref change intent on system boot. As landed, we'll act as if Fennec was launched whenever the phone is rebooted.
mfinkle, please redirect or review!

This calls a (soon to be) public static method in the Announcements service to write out the current time as a "last launched" value. This allows us to determine idle days.

Alternatives were to write the pref directly (brittle), broadcast an intent (verbose), or tag along on the enabled-pref broadcast (janky).
Attachment #676440 - Flags: review?(mark.finkle)
Attached patch Services part. v1 (obsolete) — Splinter Review
Attachment #676481 - Flags: review?(liuche)
I'll kill that info log tag after testing, btw.
Part 1 reviewed on GitHub:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce2a2b464d88
Whiteboard: [snippets] → [snippets][leave open after merge]
Target Milestone: --- → Firefox 19
Attachment #676440 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1aae722faa55
Whiteboard: [snippets][leave open after merge] → [snippets]
With a follow-up to kill that log statement:

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd16afa068b9
Requesting upload for product announcements feature. Follow-up to Bug 793053.
Attachment #676755 - Flags: review+
Attachment #676755 - Flags: approval-mozilla-aurora?
Requesting upload for product announcements feature. Follow-up to Bug 793053.
Attachment #676481 - Attachment is obsolete: true
Attachment #676481 - Flags: review?(liuche)
Attachment #676756 - Flags: review?(liuche)
Attachment #676756 - Flags: approval-mozilla-aurora?
Attachment #676756 - Flags: review?(liuche) → review+
Comment on attachment 676755 [details] [diff] [review]
Aurora: Fennec hook

Approving on aurora as this is needed for Product announcements feature landing in Fx18.
Attachment #676755 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 676756 [details] [diff] [review]
Aurora: Services part.

Approving on aurora as this is needed for Product announcements feature landing in Fx18.
Attachment #676756 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.