806634 - Announcements: record browser launch in the correct place

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Richard Newman [:rnewman]]

Follow-up from bug 793053.

We need to record Fennec's launch time when Fennec actually launches, not when it sends us a pref change intent, because we *ask* for a pref change intent on system boot. As landed, we'll act as if Fennec was launched whenever the phone is rebooted.

Comment 1

[Richard Newman [:rnewman]]

https://github.com/mozilla-services/android-sync/pull/266

Comment 2

[Richard Newman [:rnewman]]

Attachment: Proposed Fennec hook. v1

mfinkle, please redirect or review!

This calls a (soon to be) public static method in the Announcements service to write out the current time as a "last launched" value. This allows us to determine idle days.

Alternatives were to write the pref directly (brittle), broadcast an intent (verbose), or tag along on the enabled-pref broadcast (janky).

Comment 3

[Richard Newman [:rnewman]]

Attachment: Services part. v1

Comment 4

[Richard Newman [:rnewman]]

I'll kill that info log tag after testing, btw.

Comment 5

[Richard Newman [:rnewman]]

Part 1 reviewed on GitHub:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce2a2b464d88

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ce2a2b464d88

Comment 7

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1aae722faa55

Comment 8

[Richard Newman [:rnewman]]

With a follow-up to kill that log statement:

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd16afa068b9

Comment 9

[Richard Newman [:rnewman]]

Attachment: Aurora: Fennec hook

Requesting upload for product announcements feature. Follow-up to Bug 793053.

Comment 10

[Richard Newman [:rnewman]]

Attachment: Aurora: Services part.

Requesting upload for product announcements feature. Follow-up to Bug 793053.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1aae722faa55
https://hg.mozilla.org/mozilla-central/rev/fd16afa068b9

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 676755 [details] [diff] [review]
Aurora: Fennec hook

Approving on aurora as this is needed for Product announcements feature landing in Fx18.

Comment 13

[bhavana bajaj [:bajaj]]

Comment on attachment 676756 [details] [diff] [review]
Aurora: Services part.

Approving on aurora as this is needed for Product announcements feature landing in Fx18.

Comment 14

[Richard Newman [:rnewman]]

   https://hg.mozilla.org/releases/mozilla-aurora/rev/39150ccd48c1
   https://hg.mozilla.org/releases/mozilla-aurora/rev/72b8e60cef45