806685 - Port browser_privatebrowsing_downloadLastDir.js and its friends to the new per-window PB APIs

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_downloadLastDir.js
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_downloadLastDir_c.js
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_downloadLastDir_toggle.js
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_DownloadLastDirWithCPS.js

In order to port this test, the files need to be copied to the perwindow/ directory, and then instead of setting privateBrowsingEnabled sequentially, the tests need to open new private browsing windows and then run the test on that window.  This involves rewriting the test structure to make it asynchronous.

Comment 1

[Andres Hernandez [:andreshm]]

Attachment: Patch v1

Comment 2

[(no longer active)]

Comment on attachment 680926 [details] [diff] [review]
Patch v1

Review of attachment 680926 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/45f947bf554a