Closed Bug 806686 Opened 7 years ago Closed 7 years ago
_privatebrowsing _geoprompt .js to the new per-window PB APIs
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_geoprompt.js In order to port this test, the file needs to be copied to the perwindow/ directory, and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.
Attachment #680930 - Flags: feedback?(ehsan)
Comment on attachment 680930 [details] [diff] [review] Patch v1 Review of attachment 680930 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_geoprompt.js @@ +18,2 @@ > > + let notification = PopupNotifications.getNotification("geolocation"); First of all, you need to access PopupNotifications from aWindow. Also, there is a whole bunch of asynchronous stuff before the notification object gets created, so you need to "wait" until that happens. I decided that I'll fix that and land the patch. Here's the changes that I made to your patch: https://gist.github.com/4068961
Attachment #680930 - Flags: feedback?(ehsan) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.