Move browser_privatebrowsing_sslsite_transition.js to the obsolete directory

RESOLVED FIXED in Firefox 19

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks 1 bug)

unspecified
Firefox 19
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

7 years ago
This test does not really apply to the new world, and we should move it to the obsolete directory.
Assignee

Comment 1

7 years ago
Posted patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #676456 - Flags: review?(josh)
Comment on attachment 676456 [details] [diff] [review]
Patch (v1)

It may be be desirable to ensure that SSL page loads are unaffected by our PB session cleanup code that will run after bug 769288 lands.
Assignee

Comment 3

7 years ago
The backstory of this code is bug 463256, where we added a terrible hack and wrote a test for the bug as described in bug 463256 comment 0.  This was a workaround to what was discovered to be bug 480619.  Then, over in bug 496335 we took out that hack but left the test in (mostly out of fear of the unknown!).  The bug in question came from the code which you took out in bug 769283.  So, now all traces of this problem are gone, especially after bug 769283 where the basic thing causing this was reworked.

We can definitely port some simulation of this test to the new APIs (by opening a PB window and closing it immediately), I guess.  But I don't see the point as it will be testing something else, entirely random.  Thus I question the value of existence of this test post per-window PB.  If you disagree, please let me know.

(/me shivers from the rush of memories of bug 463256)
Comment on attachment 676456 [details] [diff] [review]
Patch (v1)

This sounds ok to me, in that case.
Attachment #676456 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/10eca8d80a84
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.