Closed
Bug 806708
Opened 12 years ago
Closed 12 years ago
Port browser_tabMatchesInAwesomebar.js to the new per-window PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
6.56 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/browser_tabMatchesInAwesomebar.js In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window. Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
|
||
Updated•12 years ago
|
Assignee: nobody → andres
|
Assignee | |
Comment 1•12 years ago
|
||
This basically removes the PB checks from that test, since we test all interesting combinations in browser_bug816527.js. Taking this in order to help make Birch green again...
|
||
Updated•12 years ago
|
Attachment #688736 -
Flags: review?(josh) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/545107c3b807
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in
before you can comment on or make changes to this bug.
Description
•