Closed Bug 806722 Opened 7 years ago Closed 7 years ago

Port indexedDB browser_privateBrowsing.js to the new per-tab PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 19

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/test/browser_privateBrowsing.js

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #679522 - Flags: review?(josh)
Comment on attachment 679522 [details] [diff] [review]
Patch (v1)

Review of attachment 679522 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/test/browser_privateBrowsing.js
@@ +37,5 @@
> +  win.addEventListener("load", function onLoad() {
> +    win.removeEventListener("load", onLoad, false);
> +    executeSoon(function() test3(win));
> +  }, false);
> +  registerCleanupFunction(function() win.close());

registerCleanupFunction(win.close);
Attachment #679522 - Flags: review?(josh) → review+
(In reply to Josh Matthews [:jdm] from comment #2)
> Comment on attachment 679522 [details] [diff] [review]
> Patch (v1)
> 
> Review of attachment 679522 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/indexedDB/test/browser_privateBrowsing.js
> @@ +37,5 @@
> > +  win.addEventListener("load", function onLoad() {
> > +    win.removeEventListener("load", onLoad, false);
> > +    executeSoon(function() test3(win));
> > +  }, false);
> > +  registerCleanupFunction(function() win.close());
> 
> registerCleanupFunction(win.close);

That wouldn't work since the function's this pointer will be null.
https://hg.mozilla.org/mozilla-central/rev/241e44f78cff
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in before you can comment on or make changes to this bug.