806722 - Port indexedDB browser_privateBrowsing.js to the new per-tab PB APIs

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/test/browser_privateBrowsing.js

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 679522 [details] [diff] [review]
Patch (v1)

Review of attachment 679522 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/test/browser_privateBrowsing.js
@@ +37,5 @@
> +  win.addEventListener("load", function onLoad() {
> +    win.removeEventListener("load", onLoad, false);
> +    executeSoon(function() test3(win));
> +  }, false);
> +  registerCleanupFunction(function() win.close());

registerCleanupFunction(win.close);

Comment 3

[(no longer active)]

(In reply to Josh Matthews [:jdm] from comment #2)
> Comment on attachment 679522 [details] [diff] [review]
> Patch (v1)
> 
> Review of attachment 679522 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/indexedDB/test/browser_privateBrowsing.js
> @@ +37,5 @@
> > +  win.addEventListener("load", function onLoad() {
> > +    win.removeEventListener("load", onLoad, false);
> > +    executeSoon(function() test3(win));
> > +  }, false);
> > +  registerCleanupFunction(function() win.close());
> 
> registerCleanupFunction(win.close);

That wouldn't work since the function's this pointer will be null.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/241e44f78cff

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/241e44f78cff