806724 - Port browser_ConsoleStoragePBTest.js to the new per-tab PB APIs

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/dom/tests/browser/browser_ConsoleStoragePBTest.js

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.

Comment 1

[(no longer active)]

Removed this test from global PB builds: https://hg.mozilla.org/mozilla-central/rev/fd19c6212b41

Comment 2

[(no longer active)]

s/global/per-window/

Comment 3

[Mario Alvarado [:marioalv]]

Attachment: Patch to migrate the test to the new per window private mode

Comment 4

[(no longer active)]

Comment on attachment 690638 [details] [diff] [review]
Patch to migrate the test to the new per window private mode

Review of attachment 690638 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/browser/browser_ConsoleStoragePBTest.js
@@ +17,5 @@
>  
> +  function getInnerWindowId(aWindow) {
> +    return aWindow.QueryInterface(Ci.nsIInterfaceRequestor)
> +      .getInterface(Ci.nsIDOMWindowUtils)
> +        .currentInnerWindowID;

Nit: indentation.

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/3ce22cb51e56