Closed Bug 806724 Opened 8 years ago Closed 8 years ago

Port browser_ConsoleStoragePBTest.js to the new per-tab PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: marioalv)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/dom/tests/browser/browser_ConsoleStoragePBTest.js

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
Removed this test from global PB builds: https://hg.mozilla.org/mozilla-central/rev/fd19c6212b41
s/global/per-window/
Assignee: nobody → marioalv.mozilla
Status: NEW → ASSIGNED
Comment on attachment 690638 [details] [diff] [review]
Patch to migrate the test to the new per window private mode

Review of attachment 690638 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/browser/browser_ConsoleStoragePBTest.js
@@ +17,5 @@
>  
> +  function getInnerWindowId(aWindow) {
> +    return aWindow.QueryInterface(Ci.nsIInterfaceRequestor)
> +      .getInterface(Ci.nsIDOMWindowUtils)
> +        .currentInnerWindowID;

Nit: indentation.
Attachment #690638 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/3ce22cb51e56
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.