806726 - Port test_localStorageQuotaPrivateBrowsing.html to the new per-tab PB APIs

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/localstorage/test_localStorageQuotaPrivateBrowsing.html

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.

Comment 1

[(no longer active)]

Removed this test from per-window PB builds: https://hg.mozilla.org/mozilla-central/rev/e253b118cfbc

Comment 2

[Bellindira Castillo [:bellindira]]

Attachment: Ported testcase

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 693622 [details] [diff] [review]
Ported testcase

Review of attachment 693622 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the delay. Please run this through try to make sure it won't break mobile.

Comment 4

[Andres Hernandez [:andreshm]]

My account was disabled, I added a bug 825019 for that. I'll wait for the bug to run it on try.

Comment 5

[Andres Hernandez [:andreshm]]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=982751ec803a

Comment 6

[Andres Hernandez [:andreshm]]

Try is good

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/52daedcf1dbb

Comment 8

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/52daedcf1dbb