Closed Bug 806726 Opened 7 years ago Closed 7 years ago

Port test_localStorageQuotaPrivateBrowsing.html to the new per-tab PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: bellindira)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/localstorage/test_localStorageQuotaPrivateBrowsing.html

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
Removed this test from per-window PB builds: https://hg.mozilla.org/mozilla-central/rev/e253b118cfbc
Assignee: nobody → bellindira
Status: NEW → ASSIGNED
Attached patch Ported testcaseSplinter Review
Attachment #693622 - Flags: review?(ehsan)
Attachment #693622 - Flags: review?(ehsan) → review?(josh)
Comment on attachment 693622 [details] [diff] [review]
Ported testcase

Review of attachment 693622 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the delay. Please run this through try to make sure it won't break mobile.
Attachment #693622 - Flags: review?(josh) → review+
My account was disabled, I added a bug 825019 for that. I'll wait for the bug to run it on try.
Try is good
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/52daedcf1dbb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.