806729 - Port test_bug536567.html to the new per-tab PB APIs

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug536567.html

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.

Comment 1

[(no longer active)]

Removed this test from per-window PB builds: https://hg.mozilla.org/mozilla-central/rev/40d32a8843c0

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

    1.11  MOCHITEST_CHROME_FILES = \
    1.12 -		test_bug536567.html \
    1.13  		     bug536567_subframe.html \

Why leave the subframe installed?

Comment 3

[(no longer active)]

(In reply to comment #2)
> 
>     1.11  MOCHITEST_CHROME_FILES = \
>     1.12 -        test_bug536567.html \
>     1.13               bug536567_subframe.html \
> 
> Why leave the subframe installed?

It will be used later on.

Comment 4

[Andres Hernandez [:andreshm]]

Attachment: Patch v1

The test is ready, however the last tests are failing, but they should not. 
To explain further, I have found a bug, because when the observer to purge history is notified, the content pref for 'browser.update.lastDir' is not being clear on PB window. 

Using the observer to purge history:
> Services.obs.notifyObservers(null, "browser:purge-session-history", "");

The 'browser.download.lastDir' content pref is being clear fine for both PB and not PB. 
See: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/DownloadLastDir.jsm#55

But, the 'browser.update.lastDir' content pref is not being clear for both and it should. 
See: http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/nsHTMLInputElement.cpp#538

With that fixed, the test should pass fine. 

Should I file a new bug for this? Or fix it in the same patch?

Comment 5

[(no longer active)]

Comment on attachment 694590 [details] [diff] [review]
Patch v1

I'll be away starting tomorrow.  Josh can review this.

Comment 6

[Josh Matthews [:jdm]]

Eep. That's a good problem to notice, and not simple to fix :(

Comment 7

[Josh Matthews [:jdm]]

Ehsan, how do you feel about not clearing the browser.update.lastDir content pref for private windows when purging session history? My thinking is that I don't have a good way to solve the issue right now without further API changes, and it will get cleared with the closing of the private session.

Comment 8

[(no longer active)]

(In reply to Josh Matthews [:jdm] from comment #7)
> Ehsan, how do you feel about not clearing the browser.update.lastDir content
> pref for private windows when purging session history? My thinking is that I
> don't have a good way to solve the issue right now without further API
> changes, and it will get cleared with the closing of the private session.

That's fine by me.

Comment 9

[Josh Matthews [:jdm]]

Andres, the best course of action here is to fix the test to not check that the browser.download.lastDir content pref is cleared for the private window after the browser:purge-session-history notification is sent.

Comment 10

[Andres Hernandez [:andreshm]]

Attachment: Patch v2

Comment 11

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f2978b28ca2

Comment 12

[Ed Morley [:emorley]]

Backed out for test failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1f2978b28ca2

https://hg.mozilla.org/integration/mozilla-inbound/rev/442f07c8dd02

Comment 13

[Andres Hernandez [:andreshm]]

Attachment: Patch v3

Fixed the issue. Should be working fine now.

Comment 14

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/358c8fc9b59b

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/358c8fc9b59b