Closed Bug 806733 Opened 13 years ago Closed 13 years ago

Port test_sts_preloadlist.js to the new per-tab PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan.akhgari, Assigned: andreshm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/tests/unit/test_sts_preloadlist.js In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window. Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.
Bug 722979 modifies this test.
Depends on: 722979
Removed this test from per-window PB builds: https://hg.mozilla.org/mozilla-central/rev/452d72912c60
Assignee: nobody → andres
Status: NEW → ASSIGNED
Instead of using separate windows, this test should just remove uses of the private browsing service and simulate it instead (ie. use the observer service to notify "last-pb-context-exited").
(In reply to comment #3) > Instead of using separate windows, this test should just remove uses of the > private browsing service and simulate it instead (ie. use the observer service > to notify "last-pb-context-exited"). Yeah that makes sense.
Attached patch Patch v1 — — Splinter Review
Attachment #691882 - Flags: review?(ehsan)
Attachment #691882 - Flags: review?(ehsan) → review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: