Closed
Bug 806734
Opened 12 years ago
Closed 12 years ago
Port contentprefs test_bug248970.js to the new per-tab PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 19
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.46 KB,
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/contentprefs/tests/unit/test_bug248970.js In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window. Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition. (Josh, does this already have a per-window PB equivalent?)
Comment 1•12 years ago
|
||
I'm pretty sure I'm handling this in bug 723002, but not by moving it to an actual windowed implementation.
Assignee | ||
Comment 2•12 years ago
|
||
Hmm, this is all we need here.
Updated•12 years ago
|
Attachment #676761 -
Flags: review?(josh) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/97ef51f7f37a
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/97ef51f7f37a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in
before you can comment on or make changes to this bug.
Description
•