806749 - [b2g-bluetooth] Support concurrent file transfer connections

Status: RESOLVED WONTFIX

(Core :: DOM: Device Interfaces, defect)

Description

[Eric Chou [:ericchou] [:echou]]

For current design, Bluetooth*Manager inherits mozilla::ipc::UnixSocketConsumer, which means that each Bluetooth*Manager can handle only one socket connection at a time. We need to support concurrent multiple socket connections.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

I'd rather not push this into UnixSocketConsumer.

Just make BluetoothFileTransfer objects, each of which is a UnixSocketConsumer, which the BluetoothFileManager manages.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Ready to deal with this problem. Not only for the concurrent file sending scenario, but also for bug 823803, which requires to listen to two sockets(one RFCOMM, one L2CAP) at the same time.

To solve these two bugs, we need a new mechanism to handle multiple UnixSocketConsumer instances in one Bluetooth*Manager. I would like to propose a solution - Define a BluetoothSocket class, which inherits UnixSocketConsumer, and use BluetoothSocket in Bluetooth*Manager instead of UnixSocketConsumer. That would make the relation between Bluetooth*Manager and sockets changed from "is a" to "has a", and it would be more reasonable.

I just finished the first version implementation. Patches are incoming.

Comment 3

[Eric Chou [:ericchou] [:echou]]

I'm gonna move BluetoothSocket implementation to Bug 851046, then we can focus on "concurrent file transfering" here.

Comment 4

[Eric Chou [:ericchou] [:echou]]

I've decided to close this issue as resolved won't fix because I realized that concurrent file-saring seems not be neccesary if we can correctly queue file-sharing request sent from the user. Also, in reality, low-level Bluetooth implementation may not be capable of handling too many connections at a time. Last but not least, it may needs large scale modification. So close as wontfix. If we want to support (or partially support) this feature again, please file another bug.