Closed Bug 806754 Opened 9 years ago Closed 9 years ago

"ASSERTION: Stream already destroyed"

Categories

(Core :: Audio/Video, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jruderman, Assigned: roc)

References

Details

(Keywords: assertion, testcase)

Attachments

(4 files)

Attached file testcase
1. Save the testcase.
2. Fix the path in the testcase so it points at frames.webm in your tree.
3. Load the testcase.
4. Wait until the video finishes (~5 seconds).

Result:

###!!! ASSERTION: Stream already destroyed: '!aMessage->GetStream() || !aMessage->GetStream()->IsDestroyed()', file content/media/MediaStreamGraph.cpp, line 1717

The testcase is a slight perturbation of http://mxr.mozilla.org/mozilla-central/source/layout/reftests/webm-video/bug686957.html?force=1
Attached file stack
Jesse, what's the state of the art in writing tests that require GCs at particular times? Can we do that reliably?
Assignee: nobody → roc
Attachment #705233 - Flags: review?(cpearce)
As part of the test suite?  Try SpecialPowers.gc() or SpecialPowers.forceGC().

http://hg.mozilla.org/mozilla-central/file/e9f39220b8e7/testing/specialpowers/content/specialpowersAPI.js#l937
Attachment #705233 - Flags: review?(cpearce) → review+
(In reply to Jesse Ruderman from comment #3)
> As part of the test suite?  Try SpecialPowers.gc() or
> SpecialPowers.forceGC().

Does that actually reliably destroy unreachable wrapped DOM objects synchronously during the gc() call?
I don't know.  It's possible you'll need a CC too.  Play with it?
Comment on attachment 707431 [details] [diff] [review]
Part 2: fix bogus assertions and add test

Review of attachment 707431 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/test_streams_gc.html
@@ +26,5 @@
> +
> +  a.addEventListener("seeked", function() {
> +    a.play();
> +
> +	a.addEventListener("play", function() {

Mixing tabs and spaces here?
Attachment #707431 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/62f4bc028c72
https://hg.mozilla.org/mozilla-central/rev/d4a6570ca6b0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Depends on: 841809
You need to log in before you can comment on or make changes to this bug.