806770 - Strict mode warning in richlistbox.xml

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

When executing test browser_urlbarAutoFillTrimURLs.js, I get the following warning:

JavaScript Warning: "in strict mode code, functions may be declared only at top level or immediately within another function" {file: "chrome://global/content/bindings/richlistbox.xml" line: 63 column: 23 source: "              function getId(aItem) { return aItem.id; }
"}

It looks like this could be changed trivially by turning the definition to «
let getId = function getId(aItem) { return aItem.id; }
»

Comment 1

[Sunny [:darkowlzz]]

Attachment: Modified getId definition

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 704336 [details] [diff] [review]
Modified getId definition

Review of attachment 704336 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks :)

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 704336 [details] [diff] [review]
Modified getId definition

Review of attachment 704336 [details] [diff] [review]:
-----------------------------------------------------------------

You should format the patch as per the following guidelines:
http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Comment 4

[Sunny [:darkowlzz]]

Attachment: Modified getId definition

Patch formatted as per the guidelines.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad7031235de1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ad7031235de1