806781 - crash in nsXULPopupManager::UpdateMenuItems

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Scoobidiver (away)]

It first appeared in 19.0a1/20121020. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0ff60bfb3442&tochange=ff4af83233dc
It's likely a regression from bug 772808.

Signature 	nsXULPopupManager::UpdateMenuItems(nsIContent*) More Reports Search
UUID	ba447dee-0e94-44b0-a76d-7161c2121030
Date Processed	2012-10-30 01:25:50
Uptime	3
Last Crash	6.0 minutes before submission
Install Age	13.8 minutes since version was first installed.
Install Time	2012-10-30 01:12:01
Product	Firefox
Version	19.0a1
Build ID	20121029030553
Release Channel	nightly
OS	Mac OS X
OS Version	10.7.5 11G63
Build Architecture	amd64
Build Architecture Info	family 6 model 58 stepping 9
Crash Reason	EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
Crash Address	0x0
App Notes 	
AdapterVendorID: 0x10de, AdapterDeviceID: 0x fd5GL Context? GL Context+ GL Layers? GL Layers+ 
EMCheckCompatibility	True
Adapter Vendor ID	0x10de
Adapter Device ID	0x fd5

Frame 	Module 	Signature 	Source
0 	XUL 	nsXULPopupManager::UpdateMenuItems 	nsXULPopupManager.cpp:1626
1 	XUL 	nsMenuX::OnOpen 	nsMenuX.mm:585
2 	XUL 	nsMenuX::MenuOpened 	nsMenuX.mm:339
3 	XUL 	-[MenuDelegate menuWillOpen:] 	nsMenuX.mm:834
4 	AppKit 	AppKit@0x4967e9 	
5 	CoreFoundation 	CoreFoundation@0x38f9 	
6 	HIToolbox 	HIToolbox@0x50c7 	
7 	libobjc.A.dylib 	libobjc.A.dylib@0x1093c 	
8 	HIToolbox 	HIToolbox@0x7570 	
9 	Foundation 	Foundation@0x547e 	
10 	AppKit 	AppKit@0x32285f 	
11 	AppKit 	AppKit@0x1729ba 	
12 	HIToolbox 	HIToolbox@0x8695 	
13 	HIToolbox 	HIToolbox@0x8233 
...

More reports at:
https://crash-stats.mozilla.com/report/list?signature=nsXULPopupManager%3A%3AUpdateMenuItems%28nsIContent*%29

Comment 1

[Neil Deakin]

Attachment: Null-check the document

The old Mac code did this. Perhaps there's a popup that is being removed during popupshowing for some reason.

Comment 2

[[e-mail]]

Comment on attachment 676573 [details] [diff] [review]
Null-check the document

Ah, you mean bug 443455.

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/25cb48666bd6