avoid passing a "null" charset to GetUnicodeDecoder

RESOLVED FIXED in mozilla19

Status

()

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Status:
RESOLVED FIXED
Opened:
7 years ago
Updated:
3 months ago

People

(Reporter: froydnj, Unassigned)

Tracking

Version:
unspecified
Target:
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

patch
1.02 KB, patch
hsivonen
: review+
Details | Diff | Splinter Review
Reporter

Description

•
7 years ago 
mochitest logs have various numbers of lines like the following:

WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301

That's NS_ERROR_NULL_POINTER for those playing along at home.

This is annoying and bloats the logs.  It's also easily fixed.
Reporter

Comment 1

•
7 years ago
Posted patch patch — — Splinter Review 
Easy fix.  Might even make things slightly faster.
Attachment #676616 - Flags: review?(bugs)
Attachment #676616 - Flags: review?(bugs) → review?(hsivonen)
Attachment #676616 - Flags: review?(hsivonen) → review+

Comment 2

•
7 years ago 
Seems like a useless warning, though.
 Reporter

Comment 3

•
7 years ago 
(In reply to Henri Sivonen (:hsivonen) from comment #2)
> Seems like a useless warning, though.

Yeah...

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e2b4b8e759d

Comment 4

•
7 years ago 
https://hg.mozilla.org/mozilla-central/rev/6e2b4b8e759d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.