Closed Bug 806971 Opened 8 years ago Closed 8 years ago

avoid passing a "null" charset to GetUnicodeDecoder

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla19

People

(Reporter: froydnj, Unassigned)

Details

Attachments

(1 file)

patch
1.02 KB, patch
hsivonen
: review+
Details | Diff | Splinter Review 
mochitest logs have various numbers of lines like the following:

WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301

That's NS_ERROR_NULL_POINTER for those playing along at home.

This is annoying and bloats the logs.  It's also easily fixed.
Attached patch patch — — Splinter Review 
Easy fix.  Might even make things slightly faster.
Attachment #676616 - Flags: review?(bugs)
Attachment #676616 - Flags: review?(bugs) → review?(hsivonen)
Attachment #676616 - Flags: review?(hsivonen) → review+
Seems like a useless warning, though.
(In reply to Henri Sivonen (:hsivonen) from comment #2)
> Seems like a useless warning, though.

Yeah...

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e2b4b8e759d
https://hg.mozilla.org/mozilla-central/rev/6e2b4b8e759d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.