Closed
Bug 807034
Opened 12 years ago
Closed 12 years ago
WebIDL bindings fail to compile for static readonly attributes.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: wchen, Assigned: wchen)
Details
Attachments
(1 file)
2.49 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Getting these errors when trying to compile the Notification bindings. 41.22 /Users/wchen/mozilla/obj-ff-dbg/dom/bindings/NotificationBinding.cpp:471:23: error: no member named 'Unwrap' in namespace 'XPCWrapper'; did you mean 'xpc::Unwrap'? 41.22 obj = XPCWrapper::Unwrap(cx, obj, false); 41.22 ~~~~~~~~~~~~^~~~~~ 41.22 xpc::Unwrap 41.22 /Users/wchen/mozilla/js/xpconnect/src/xpcpublic.h:283:1: note: 'xpc::Unwrap' declared here 41.22 Unwrap(JSContext *cx, JSObject *wrapper, bool stopAtOuter = true); 41.22 ^ 41.22 /Users/wchen/mozilla/obj-ff-dbg/dom/bindings/NotificationBinding.cpp:509:23: error: no member named 'Unwrap' in namespace 'XPCWrapper'; did you mean 'xpc::Unwrap'? 41.22 obj = XPCWrapper::Unwrap(cx, obj, false); 41.23 ~~~~~~~~~~~~^~~~~~ 41.23 xpc::Unwrap 41.23 /Users/wchen/mozilla/js/xpconnect/src/xpcpublic.h:283:1: note: 'xpc::Unwrap' declared here 41.23 Unwrap(JSContext *cx, JSObject *wrapper, bool stopAtOuter = true); 41.23 ^ 41.23 /Users/wchen/mozilla/obj-ff-dbg/dom/bindings/NotificationBinding.cpp:845:147: error: use of undeclared identifier 'set_permission' 41.23 { "permission", 0, JSPROP_SHARED | JSPROP_ENUMERATE | JSPROP_NATIVE_ACCESSORS, { (JSPropertyOp)get_permission, nullptr }, { (JSStrictPropertyOp)set_permission, nullptr }},
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #676687 -
Flags: review?(peterv)
Comment 2•12 years ago
|
||
Comment on attachment 676687 [details] [diff] [review] Fixed WebIDL codegen for static readonly attributes. r=me. Looks like this was a rebase failure? The older patches in bug 763643 do this right....
Attachment #676687 -
Flags: review?(peterv) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 3•12 years ago
|
||
Hmm, not sure what happened there. Thanks for the fix.
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/00a6fa232bec
Flags: in-testsuite-
Keywords: checkin-needed
Comment 5•12 years ago
|
||
Actually, we should add a test.... I'm surprised bug 763643 didn't. William, want to do that?
Flags: in-testsuite- → in-testsuite?
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/00a6fa232bec
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•