807034 - WebIDL bindings fail to compile for static readonly attributes.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[William Chen [:wchen]]

Getting these errors when trying to compile the Notification bindings.

    41.22 /Users/wchen/mozilla/obj-ff-dbg/dom/bindings/NotificationBinding.cpp:471:23: error: no member named 'Unwrap' in namespace 'XPCWrapper'; did you mean 'xpc::Unwrap'?
    41.22     obj = XPCWrapper::Unwrap(cx, obj, false);
    41.22           ~~~~~~~~~~~~^~~~~~
    41.22                       xpc::Unwrap
    41.22 /Users/wchen/mozilla/js/xpconnect/src/xpcpublic.h:283:1: note: 'xpc::Unwrap' declared here
    41.22 Unwrap(JSContext *cx, JSObject *wrapper, bool stopAtOuter = true);
    41.22 ^
    41.22 /Users/wchen/mozilla/obj-ff-dbg/dom/bindings/NotificationBinding.cpp:509:23: error: no member named 'Unwrap' in namespace 'XPCWrapper'; did you mean 'xpc::Unwrap'?
    41.22     obj = XPCWrapper::Unwrap(cx, obj, false);
    41.23           ~~~~~~~~~~~~^~~~~~
    41.23                       xpc::Unwrap
    41.23 /Users/wchen/mozilla/js/xpconnect/src/xpcpublic.h:283:1: note: 'xpc::Unwrap' declared here
    41.23 Unwrap(JSContext *cx, JSObject *wrapper, bool stopAtOuter = true);
    41.23 ^
    41.23 /Users/wchen/mozilla/obj-ff-dbg/dom/bindings/NotificationBinding.cpp:845:147: error: use of undeclared identifier 'set_permission'
    41.23   { "permission", 0, JSPROP_SHARED | JSPROP_ENUMERATE | JSPROP_NATIVE_ACCESSORS, { (JSPropertyOp)get_permission, nullptr }, { (JSStrictPropertyOp)set_permission, nullptr }},

Comment 1

[William Chen [:wchen]]

Attachment: Fixed WebIDL codegen for static readonly attributes.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 676687 [details] [diff] [review]
Fixed WebIDL codegen for static readonly attributes.

r=me.  Looks like this was a rebase failure?  The older patches in bug 763643 do this right....

Comment 3

[Peter Van der Beken [:peterv]]

Hmm, not sure what happened there. Thanks for the fix.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00a6fa232bec

Comment 5

[Boris Zbarsky [:bzbarsky]]

Actually, we should add a test....  I'm surprised bug 763643 didn't.  William, want to do that?

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/00a6fa232bec