807119 - Update mozbase's emulator classes

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Jonathan Griffin (:jgriffin)]

emulator.py and b2gemulator.py in mozdevice are currently quite out-of-date, when compared with Marionette's emulator.py.  We should merge all the recent changes from this file into the mozbase version, so we can refactor Marionette to use it.

Comment 1

[Jonathan Griffin (:jgriffin)]

Actually I believe we decided to remove the emulator classes from mozbase altogether, but I never got around to it.  Any objections to that plan?  If not, I'll change this bug.

Comment 2

[Jeff Hammel]

No objections from me assuming its not being used anywhere.  If we need it in the future, we can add it.

Comment 3

[Jeff Hammel]

In addition, of course, we shouldn't have this code in multiple places

Comment 4

[Jonathan Griffin (:jgriffin)]

(In reply to Jeff Hammel [:jhammel] from comment #3)
> In addition, of course, we shouldn't have this code in multiple places

I agree.  Our original intention was to remove the emulator classes from Marionette and just use the one in mozbase.  We didn't end up doing that due to the fast pace of changes required last quarter, and wanting to avoid the time lag needed to mirror mozbase from github each time we made a change.

No one is currently using the mozbase emulator packages, so it is safe to remove.

Comment 5

[Jeff Hammel]

SGTM, let's do it.  We have bigger fish to fry

Comment 6

[Andrew Halberstadt [:ahal]]

Lets remove it for now. I don't think marionette is the right place for emulator.py to live, but I'm not sure if mozbase is either. We can figure this out later though and always add it back in if we need to.

Comment 7

[Jeff Hammel]

+1. I don't know if mozdevice is the right place for it to live, either.  But I do think that when we add in this code we should do it on a as needed basis.

Also, emulator_battery.py should be removed as well

Comment 8

[Jeff Hammel]

Attachment: remove emulator classes

Comment 9

[Jonathan Griffin (:jgriffin)]

Comment on attachment 706443 [details] [diff] [review]
remove emulator classes

Review of attachment 706443 [details] [diff] [review]:
-----------------------------------------------------------------

Nuke it!

Comment 10

[Jeff Hammel]

pushed: https://github.com/mozilla/mozbase/commit/28f7740e72f6358a23965e24639747ca5a048c11

http://k0s.org:8010/builders/mozbase%20-%20linux/builds/270/steps/shell_5/logs/stdio

Comment 11

[Jeff Hammel]

follow up: https://github.com/mozilla/mozbase/commit/32d9ed23a1a23e43486c71139b1a6ee51d36f6ae