Closed
Bug 807207
Opened 12 years ago
Closed 9 years ago
Failing to install fennec should not result in DISCONNECTED state
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Assigned: bc)
Details
Attachments
(1 file)
In the worker subprocess, if we fail to install fennec, we mark the phone as disconnected. This doesn't make sense, since it might really be a bad build. We can retry a phone times, then we should fail the job and return to idle state.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bob
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
This bug as filed is fixed by Bug 1133580 but there is another issue that can kill the worker if the build.apk is corrupted. I edited an existing build.apk and removed the first line. Instead of a zipfile.BadZipfile exception it caused an IOError during a trigger_runs.py: Exception happened during processing of request from ('127.0.0.1', 45042) Traceback (most recent call last): File "/usr/lib64/python2.7/SocketServer.py", line 595, in process_request_thread self.finish_request(request, client_address) File "/usr/lib64/python2.7/SocketServer.py", line 334, in finish_request self.RequestHandlerClass(request, client_address, self) File "/usr/lib64/python2.7/SocketServer.py", line 651, in __init__ self.handle() File "/mozilla/projects/autophone/src/bclary-autophone/buildserver.py", line 55, in handle enable_unittests=enable_unittests) File "/mozilla/projects/autophone/src/bclary-autophone/builds.py", line 610, in get zipfile.ZipFile(build_path).testzip() is not None) File "/usr/lib64/python2.7/zipfile.py", line 898, in testzip with self.open(zinfo.filename, "r") as f: File "/usr/lib64/python2.7/zipfile.py", line 963, in open zef_file.seek(zinfo.header_offset, 0) IOError: [Errno 22] Invalid argument This fixes it for me locally.
Attachment #8586843 -
Flags: review?(mcote)
Reporter | ||
Updated•9 years ago
|
Attachment #8586843 -
Flags: review?(mcote) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://github.com/mozilla/autophone/commit/8ee1dd0aa8b3c135143d9673b5b110f98b8417d0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•