Closed Bug 807213 Opened 8 years ago Closed 8 years ago

Stop creating nsSVGMarkerProperty objects for non-nsSVGPathGeometryFrame frames

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox17 + fixed
firefox18 + fixed
firefox19 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

The only frame type that uses SVG markers is nsSVGPathGeometryFrame. We should stop wastefully creating nsSVGMarkerProperty objects for other frame types.
Attached patch patchSplinter Review
Attachment #676899 - Flags: review?(roc)
Looking forward to tmrw when it lands to mozilla-central :) and i can reenable fuzzing markers :)
Attachment #676899 - Attachment is patch: true
https://hg.mozilla.org/mozilla-central/rev/734c42e76813
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment on attachment 676899 [details] [diff] [review]
patch

We should take this on branches.
Attachment #676899 - Flags: approval-mozilla-esr17?
Attachment #676899 - Flags: approval-mozilla-beta?
Attachment #676899 - Flags: approval-mozilla-aurora?
Comment on attachment 676899 [details] [diff] [review]
patch

As per email, go ahead with uplift on this, we know the risk to be low.  I'm clearing the ESR17 flag since we'll get this on the first ESR17 by virtue of it getting on mozilla-beta now (17).
Attachment #676899 - Flags: approval-mozilla-esr17?
Attachment #676899 - Flags: approval-mozilla-beta?
Attachment #676899 - Flags: approval-mozilla-beta+
Attachment #676899 - Flags: approval-mozilla-aurora?
Attachment #676899 - Flags: approval-mozilla-aurora+
Jonathan: is this fixing a long-standing issue or is this fixing a regression in Firefox 17?
Flags: needinfo?(jwatt)
Blocks: 795740
The patch fixes a long-standing issue in the code, although it's unclear what the consequences of that issue are in the various versions of Firefox.
Flags: needinfo?(jwatt)
Blocks: 795734
You need to log in before you can comment on or make changes to this bug.