The default bug view has changed. See this FAQ.

Stop creating nsSVGMarkerProperty objects for non-nsSVGPathGeometryFrame frames

RESOLVED FIXED in Firefox 17

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla19
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox17+ fixed, firefox18+ fixed, firefox19 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The only frame type that uses SVG markers is nsSVGPathGeometryFrame. We should stop wastefully creating nsSVGMarkerProperty objects for other frame types.
(Assignee)

Comment 1

5 years ago
Created attachment 676899 [details] [diff] [review]
patch
Attachment #676899 - Flags: review?(roc)
Attachment #676899 - Flags: review?(roc) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/734c42e76813
Version: 17 Branch → Trunk

Comment 3

5 years ago
Looking forward to tmrw when it lands to mozilla-central :) and i can reenable fuzzing markers :)

Updated

5 years ago
Attachment #676899 - Attachment is patch: true
https://hg.mozilla.org/mozilla-central/rev/734c42e76813
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(Assignee)

Comment 5

5 years ago
Comment on attachment 676899 [details] [diff] [review]
patch

We should take this on branches.
Attachment #676899 - Flags: approval-mozilla-esr17?
Attachment #676899 - Flags: approval-mozilla-beta?
Attachment #676899 - Flags: approval-mozilla-aurora?
status-firefox17: --- → affected
status-firefox18: --- → affected
status-firefox19: --- → fixed
tracking-firefox17: --- → +
tracking-firefox18: --- → +
Comment on attachment 676899 [details] [diff] [review]
patch

As per email, go ahead with uplift on this, we know the risk to be low.  I'm clearing the ESR17 flag since we'll get this on the first ESR17 by virtue of it getting on mozilla-beta now (17).
Attachment #676899 - Flags: approval-mozilla-esr17?
Attachment #676899 - Flags: approval-mozilla-beta?
Attachment #676899 - Flags: approval-mozilla-beta+
Attachment #676899 - Flags: approval-mozilla-aurora?
Attachment #676899 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/062ae9c63641
https://hg.mozilla.org/releases/mozilla-beta/rev/f6d38889deab
status-firefox17: affected → fixed
status-firefox18: affected → fixed
Jonathan: is this fixing a long-standing issue or is this fixing a regression in Firefox 17?
Flags: needinfo?(jwatt)
Blocks: 795740
(Assignee)

Comment 9

4 years ago
The patch fixes a long-standing issue in the code, although it's unclear what the consequences of that issue are in the various versions of Firefox.
Flags: needinfo?(jwatt)
Blocks: 795734
You need to log in before you can comment on or make changes to this bug.