Closed
Bug 807274
Opened 10 years ago
Closed 10 years ago
[markup view] Clicking on a node doesn't lock the highlighter
Categories
(DevTools :: Inspector, defect, P1)
Tracking
(firefox18 fixed, firefox19 fixed)
RESOLVED
FIXED
People
(Reporter: djc, Assigned: paul)
Details
Attachments
(1 file)
837 bytes,
patch
|
dcamp
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This happens in 18.0a2 (2012-10-28). The Style pane still shows element content if you click an element in the browser part of the content area, so something about the inspector is broken.
Assignee | ||
Comment 1•10 years ago
|
||
This is not very clear. Can you share some STR?
Reporter | ||
Comment 2•10 years ago
|
||
1. CTRL + Shift + I to open the Inspector 2. Click Style button on the lower right (Style pane appears, "No element selected") 3. In the DOM tree, click an element node: Style pane stays at "No element selected" Desired result: when click an element node in the DOM tree, the same thing should happen as when I click a node in the main browser area or the breadcrumbs at the bottom of the inspector.
Assignee | ||
Comment 3•10 years ago
|
||
Indeed.
Assignee | ||
Updated•10 years ago
|
Summary: Clicking element in inspector doesn't open element in Style pane → [markup view] Clicking on a node doesn't lock the highlighter
Assignee | ||
Updated•10 years ago
|
OS: Windows 7 → All
Hardware: x86_64 → All
Reporter | ||
Comment 4•10 years ago
|
||
Can someone please look at this? It seems like a significant regression that's not too hard to fix.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → paul
Assignee | ||
Comment 5•10 years ago
|
||
I never fixed that. And it's broken in Beta -> P1
Priority: -- → P1
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #686545 -
Flags: review?(dcamp)
Updated•10 years ago
|
Attachment #686545 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 7•10 years ago
|
||
This needs to go into beta and aurora, but not in nightly. https://tbpl.mozilla.org/?tree=Try&rev=4f2d8a6807ee
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 686545 [details] [diff] [review] patch v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Inspector behaves strangely (every time you would click on a node in the DOM View, overring the page would change the selection) Testing completed (on m-c, etc.): my computer and try: https://tbpl.mozilla.org/?tree=Try&rev=4f2d8a6807ee (we don't want it in m-c) Risk to taking this patch (and alternatives if risky): medium (not heavily tested) String or UUID changes made by this patch: no
Attachment #686545 -
Flags: approval-mozilla-beta?
Attachment #686545 -
Flags: approval-mozilla-aurora?
Comment 9•10 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #8) > Risk to taking this patch (and alternatives if risky): medium (not heavily > tested) This hasn't been on our tracking radar, and we're approaching our fourth beta. Does this have the possibility of causing a new regression that, if shipped in FF18, you would advocate a re-spin for? Who typically performs devtools QA for you all, to take a look at the change in Aurora and subsequently Beta?
Updated•10 years ago
|
Attachment #686545 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to Alex Keybl [:akeybl] from comment #9) > (In reply to Paul Rouget [:paul] from comment #8) > > Risk to taking this patch (and alternatives if risky): medium (not heavily > > tested) > > This hasn't been on our tracking radar, and we're approaching our fourth > beta. Does this have the possibility of causing a new regression that, if > shipped in FF18, you would advocate a re-spin for? Not very likely to cause a new regression. If any regression happen, I can't really tell what would be its nature, but surely nothing that would require a re-spin. > Who typically performs devtools QA for you all, to take a look at the change > in Aurora and subsequently Beta? Afaik, nobody. If we get the approval for beta, I will make sure that someone will be actively working on testing the affected features in beta and aurora.
Comment 11•10 years ago
|
||
Comment on attachment 686545 [details] [diff] [review] patch v1 Thanks Paul - this sounds like manageable risk in that case.
Attachment #686545 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 12•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/376035760ee0
Assignee | ||
Comment 13•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/3040211d5324
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•