Closed
Bug 807279
Opened 12 years ago
Closed 12 years ago
Add API to access Favicons without requiring mAppContext
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: lucasr, Assigned: lucasr)
Details
Attachments
(1 file)
|
11.75 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Right now, AllPagesTab is using GeckoApp.mAppContext.getFavicons() to do it, which is not ideal.
|
Assignee | |
Comment 1•12 years ago
|
||
I'm usually not a fan of singletons but I think it does make sense in this case. We were originally only using Favicons in GeckoApp but now we're using it in multiple places. Also, we don't want to drop the Favicons memcache every time the GeckoApp activity is destroyed (e.g. when "don't keep activities" is on).
Attachment #687090 -
Flags: review?(mark.finkle)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 687090 [details] [diff] [review]
Turn Favicons into a singleton
Looks good
Attachment #687090 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•