Windows 8 N builds should call SHChangeNotify as per documentation

RESOLVED FIXED in Firefox 19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

unspecified
Firefox 19
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
I found more about the European Economic Area (EEA) builds here:

The Windows 8 Metro Style Enabled Desktop Browser whitepaper says that for these builds ( http://windows.microsoft.com/en-GB/windows-8/n-editions ) we should be calling:

  SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_DWORD | SHCNF_FLUSH, nullptr, nullptr);

Exactly like that at the end of installations.
(Assignee)

Comment 1

6 years ago
We were already calling it without these parameters: SHCNF_DWORD | SHCNF_FLUSH

So this bug is just to add those.
(Assignee)

Comment 2

6 years ago
Created attachment 677049 [details] [diff] [review]
Patch v1

Fixup calls as per documentation
Attachment #677049 - Flags: review?(jmathies)

Comment 3

6 years ago
Comment on attachment 677049 [details] [diff] [review]
Patch v1

Hopefully this will fix the annoying icon refresh on update.
Attachment #677049 - Flags: review?(jmathies) → review+
(Assignee)

Comment 4

6 years ago
It won't :) I only added the extra params to the installer. I don't think they make a difference in terms of refresh though.
(Assignee)

Comment 5

6 years ago
To get rid of that flash on updates we'd have to add an ApplicationID::Get, and then only conditionally call ApplicationID::Set and the shell taskbar updated notify call.
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/d2dd55e48c4c
Target Milestone: --- → Firefox 19

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/d2dd55e48c4c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.