Closed Bug 807357 Opened 10 years ago Closed 10 years ago

Windows 8 N builds should call SHChangeNotify as per documentation

Categories

(Firefox :: Installer, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 19

People

(Reporter: bbondy, Assigned: bbondy)

Details

Attachments

(1 file)

I found more about the European Economic Area (EEA) builds here:

The Windows 8 Metro Style Enabled Desktop Browser whitepaper says that for these builds ( http://windows.microsoft.com/en-GB/windows-8/n-editions ) we should be calling:

  SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_DWORD | SHCNF_FLUSH, nullptr, nullptr);

Exactly like that at the end of installations.
We were already calling it without these parameters: SHCNF_DWORD | SHCNF_FLUSH

So this bug is just to add those.
Attached patch Patch v1Splinter Review
Fixup calls as per documentation
Attachment #677049 - Flags: review?(jmathies)
Comment on attachment 677049 [details] [diff] [review]
Patch v1

Hopefully this will fix the annoying icon refresh on update.
Attachment #677049 - Flags: review?(jmathies) → review+
It won't :) I only added the extra params to the installer. I don't think they make a difference in terms of refresh though.
To get rid of that flash on updates we'd have to add an ApplicationID::Get, and then only conditionally call ApplicationID::Set and the shell taskbar updated notify call.
https://hg.mozilla.org/mozilla-central/rev/d2dd55e48c4c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.