807357 - Windows 8 N builds should call SHChangeNotify as per documentation

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Brian R. Bondy [:bbondy]]

I found more about the European Economic Area (EEA) builds here:

The Windows 8 Metro Style Enabled Desktop Browser whitepaper says that for these builds ( http://windows.microsoft.com/en-GB/windows-8/n-editions ) we should be calling:

  SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_DWORD | SHCNF_FLUSH, nullptr, nullptr);

Exactly like that at the end of installations.

Comment 1

[Brian R. Bondy [:bbondy]]

We were already calling it without these parameters: SHCNF_DWORD | SHCNF_FLUSH

So this bug is just to add those.

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

Fixup calls as per documentation

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 677049 [details] [diff] [review]
Patch v1

Hopefully this will fix the annoying icon refresh on update.

Comment 4

[Brian R. Bondy [:bbondy]]

It won't :) I only added the extra params to the installer. I don't think they make a difference in terms of refresh though.

Comment 5

[Brian R. Bondy [:bbondy]]

To get rid of that flash on updates we'd have to add an ApplicationID::Get, and then only conditionally call ApplicationID::Set and the shell taskbar updated notify call.

Comment 6

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d2dd55e48c4c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d2dd55e48c4c