Closed
Bug 807360
Opened 12 years ago
Closed 12 years ago
Rename FullScreenDeniedIframeDisallowed in dom.properties to reflect string change
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla19
Tracking | Status | |
---|---|---|
firefox19 | - | --- |
People
(Reporter: flod, Assigned: cpearce)
References
Details
Attachments
(1 file)
3.34 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
See https://bugzilla.mozilla.org/show_bug.cgi?id=805301#c17
Relevant changeset
http://hg.mozilla.org/mozilla-central/diff/9c5a898efbe9/dom/locales/en-US/chrome/dom/dom.properties
String had a significant change but the key remained the same
Updated•12 years ago
|
tracking-firefox19:
--- → ?
Assignee | ||
Comment 1•12 years ago
|
||
Ooops! I totally should have remembered to do this. Thanks for pointing this out!
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Attachment #677196 -
Flags: review?(justin.lebar+bug)
Updated•12 years ago
|
Attachment #677196 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Assignee | ||
Comment 4•12 years ago
|
||
Comment on attachment 677196 [details] [diff] [review]
Patch: Rename changed string
[Approval Request Comment]
This patch changes the ID of the string used to log to the web console when a fullscreen by content inside an <iframe> is denied because a "allowfullscreen" attribute isn't present on the <iframe>, I forgot to include this change in my patch for bug 805301.
Bug caused by (feature/regressing bug #): Fullscreen.
User impact if declined: String change in bug 805301 won't be picked up by localizers.
Testing completed (on m-c, etc.): It's been on m-c for a few days.
Risk to taking this patch (and alternatives if risky): Low risk.
String or UUID changes made by this patch: Yes.
Attachment #677196 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•12 years ago
|
Attachment #677196 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•