Closed Bug 807360 Opened 7 years ago Closed 7 years ago
Screen Denied Iframe Disallowed in dom .properties to reflect string change
See https://bugzilla.mozilla.org/show_bug.cgi?id=805301#c17 Relevant changeset http://hg.mozilla.org/mozilla-central/diff/9c5a898efbe9/dom/locales/en-US/chrome/dom/dom.properties String had a significant change but the key remained the same
Ooops! I totally should have remembered to do this. Thanks for pointing this out!
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Attachment #677196 - Flags: review?(justin.lebar+bug)
Attachment #677196 - Flags: review?(justin.lebar+bug) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment on attachment 677196 [details] [diff] [review] Patch: Rename changed string [Approval Request Comment] This patch changes the ID of the string used to log to the web console when a fullscreen by content inside an <iframe> is denied because a "allowfullscreen" attribute isn't present on the <iframe>, I forgot to include this change in my patch for bug 805301. Bug caused by (feature/regressing bug #): Fullscreen. User impact if declined: String change in bug 805301 won't be picked up by localizers. Testing completed (on m-c, etc.): It's been on m-c for a few days. Risk to taking this patch (and alternatives if risky): Low risk. String or UUID changes made by this patch: Yes.
You need to log in before you can comment on or make changes to this bug.