807410 - Pass some things to the nsJSContext constructor instead of using setters

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Global object

SetGCOnDestruction and SetGlobalObject are only used right after we constructed the object. Making those constructor arguments makes that clearer.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: GC on destruction

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 677075 [details] [diff] [review]
Part a: Global object

- In class nsJSRuntime:

-  virtual already_AddRefed<nsIScriptContext> CreateContext();
+  virtual already_AddRefed<nsIScriptContext> CreateContext(nsIScriptGlobalObject* aGlobalObject = nullptr);

Why a default value? I'd much rather see callers of this being explicit.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Because only nsGlobalWindow passed one, but sure.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 677075 [details] [diff] [review]
Part a: Global object

r=jst, but please remove the default argument and make the few callers of CreateContext() be explicit about what they want to pass in.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 677077 [details] [diff] [review]
Part b: GC on destruction

r=jst. Thanks for the patches!

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/40e08e6b0fda
https://hg.mozilla.org/mozilla-central/rev/8e21cdfce89c