Last Comment Bug 807451 - Remove nsISignatureVerifier and/or nsISignatureVerifier::VerifySignature
: Remove nsISignatureVerifier and/or nsISignatureVerifier::VerifySignature
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Thunderbird 19.0
Assigned To: Mark Banner (:standard8, limited time in Dec)
:
:
Mentors:
Depends on:
Blocks: 775698 805305
  Show dependency treegraph
 
Reported: 2012-10-31 13:25 PDT by Mark Banner (:standard8, limited time in Dec)
Modified: 2013-02-07 19:14 PST (History)
4 users (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
The fix (8.77 KB, patch)
2012-10-31 13:32 PDT, Mark Banner (:standard8, limited time in Dec)
neil: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8, limited time in Dec) 2012-10-31 13:25:42 PDT
+++ This bug was initially created as a clone of Bug #805305 +++

This does a public key operation on the main thread. It is not used by any addons on AMO (according to MXR) and it's only use within Gecko will go away soon. MailNews uses it, but only to initialize PSM and/or to check if PSM exists; I will provide MailNews with another technique for initializing PSM.
Comment 1 Mark Banner (:standard8, limited time in Dec) 2012-10-31 13:32:32 PDT
Created attachment 677148 [details] [diff] [review]
The fix

This does what Brian suggests in bug 805305 comment 1. It looks like all but one of the cases were detecting if psm was included or not (which really should have been build config switches!).
Comment 2 neil@parkwaycc.co.uk 2012-11-02 05:34:59 PDT
Comment on attachment 677148 [details] [diff] [review]
The fix

[Surely the correct way to do these checks would have been to try to instantiate the appropriate auth module? Also, interesting that IMAP doesn't even bother.]
Comment 3 Mark Banner (:standard8, limited time in Dec) 2012-11-02 10:11:00 PDT
https://hg.mozilla.org/comm-central/rev/b2d52e305718
Comment 4 jack ping hua zhan 2013-02-07 19:14:40 PST
I wasted 2 days on looking for the reason why this interface is not usable with javascript. It does not even show up in the firefox. eventually, I came to here. I would say, this interface is not bad.
if you can keep it, then with window.crypto.signText, I can sign on something
and with this iterface, I can verify something.

This interface is especially good to be called from content page. since it does not require the caller to find the certificate.

can we keep this and make it scriptable? or add it to the crypto?

Note You need to log in before you can comment on or make changes to this bug.