Closed Bug 807465 Opened 7 years ago Closed 7 years ago

Less QIs in nsXULPopupManager::UpdateMenuItems

Categories

(Core :: XUL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
There is no point in using nsIDOM* interfaces here.
Attachment #677156 - Flags: review?
Attachment #677156 - Flags: review? → review?(enndeakin)
Comment on attachment 677156 [details] [diff] [review]
Patch v1

>+        nsRefPtr<dom::Element> commandElt = document->GetElementById(command);
>+        if (commandElement) {

You meant to assign to 'commandElement' not 'commandElt'.
Yes, I did. Looks like I forgot to refresh my patch after fixing that.
Comment on attachment 677156 [details] [diff] [review]
Patch v1

This is ok then assuming that change gets made.
Attachment #677156 - Flags: review?(enndeakin) → review+
https://hg.mozilla.org/mozilla-central/rev/cac8275e885b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.