Closed Bug 807683 Opened 8 years ago Closed 7 years ago

make ALSA a configure option

Categories

(Core :: Audio/Video, defect)

x86_64
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attachment #677435 - Flags: review?(kinetik)
Blocks: 807492
Depends on: 780531
Comment on attachment 677435 [details] [diff] [review]
Bug 807683 - Convert ALSA to a configure option.

This is okay with me, but a build peer should review this.
Attachment #677435 - Flags: review?(kinetik) → feedback+
Attachment #677435 - Flags: review?(khuey)
Comment on attachment 677435 [details] [diff] [review]
Bug 807683 - Convert ALSA to a configure option.

Review of attachment 677435 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5638,4 @@
>  dnl If using sydneyaudio with Linux, ensure that the alsa library is available
> +if test -n "$MOZ_SYDNEYAUDIO" -a "$OS_TARGET" = "Linux" -a "$MOZ_ALSA_FORCE" != "no"; then
> +    MOZ_ALSA=1
> +fi

Put this above the MOZ_ARG_ENABLE_BOOL and then drop the MOZ_ALSA_FORCE stuff.
Attachment #677435 - Flags: review?(khuey) → review+
Attachment #677435 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/828a19e29014
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Blocks: 844818
You need to log in before you can comment on or make changes to this bug.