807709 - Downloads Panel does not always close when handing off operations to the OS

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR on Ubuntu:

1) Start a download and wait for it to complete.
2) When the download completes, open the panel, and click on the folder icon to open up its containing folder.

What happens?

Nautilus opens up as expected, and is focused. The Downloads Panel is, however, still open, and visible overtop of Nautilus.

What's expected?

The panel should close once we choose the "Open Containing Folder" action, like on Windows and OSX.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Workaround

Pretty sure this is a platform panel bug.

I've filed bug 807774 to deal with it.

In the meantime, here's the workaround.

Comment 2

[Marco Bonardo [:mak]]

let's first figure out how much time may take a platform fix, doesn't look that hard at first glance.

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 677535 [details] [diff] [review]
Workaround

Review of attachment 677535 [details] [diff] [review]:
-----------------------------------------------------------------

Karl pointed out some good points why we may still want to close the panel regardless bug 807774.

Among those, I think the worst experience we have right now is the user clicking multiple times to open an item and ending up with multiple openings cause there's no feedback at all.
Also if the opening fails we have no way to give back feedback so it looks like a broken click action.
Thus I think it's fine to react to the action by explicitly closing the panel, to indicate we handled the request (whatever is the result), this is even more specific popup behavior (action that has an effect outside of the popup closes it). This should also help perceived responsiveness.

Please just update the comment by stating a sum up of the above, since we want this behavior regardless reveal() behavior.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2

Ok, updated the comment, and now we also explicitly close the panel when opening a file (for pretty much the same reason).

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Landed on mozilla-inbound as https://hg.mozilla.org/integration/mozilla-inbound/rev/358efbbf8c08

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/358efbbf8c08

Comment 7

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly - the Downloads panel is closed when handing off operations to the OS (verified by using the STR from the Description).

Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/19.0 Firefox/19.0
Build ID: 20121113030658