Closed Bug 807760 Opened 7 years ago Closed 7 years ago

Only enable OMTC for certain platforms

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox18 fixed, firefox19 fixed)

RESOLVED FIXED
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: jdm, Assigned: jdm)

References

Details

Attachments

(1 file)

Currently b2g.js unconditionally enables OMTC. This is bad for local desktop builds, and possibly desktop nightlies. We should disable it at least for Windows, where I've seen it cause startup crashes.
Attachment #677525 - Flags: review?(jones.chris.g)
Assignee: nobody → josh
Blocks: 795484
In my testing, disabling OMTC on Windows does enable B2G to start up without crashing, but it has a couple side-effects: the B2G wallpaper is replaced by a black background; and a mouse click-and-drag, which simulates a finger swipe on an actual device, doesn't cause a repaint until the next event is dispatched.
Comment on attachment 677525 [details] [diff] [review]
Disable OMTC in b2g builds on Windows.

You can drop the #else because this defaults to false.  Please link a FIXME/bug XXXXX in a comment here.

r=me with that
Attachment #677525 - Flags: review?(jones.chris.g) → review+
Chris, should this be disabled for desktop builds in general, since it's a fairly unsupported setup at this point? Are we able to differentiate between device and desktop builds?
It's also disabled on x11 builds, although that's not obvious from the pref.  (x11 is a special snowflake.)

My understanding is that omtc on mac is pretty stable, but I don't use a mac so I don't have firsthand evidence.  CC'ing some folks who know better.
I ran OMTC mac build by default for daily browsing for about a month where it was stable minus a few buffer rotation bugs. And if it isn't then we've got a regression on our hands.
OMTC mac is fine right now, at least for casual browsing (I'm not using it full time, but I haven't seen it crash or mis-render for a long time).
Comment on attachment 677525 [details] [diff] [review]
Disable OMTC in b2g builds on Windows.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Startup crashes for windows b2g desktop builds.
Testing completed (on m-c, etc.): Multiple b2g desktop builds across several machines that did not start and now do.
Risk to taking this patch (and alternatives if risky): The risk of shipping a desktop build that is actually usable.
String or UUID changes made by this patch: None.
Attachment #677525 - Flags: approval-mozilla-aurora?
Attachment #677525 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: checkin-needed
Whiteboard: [checkin-needed for aurora]
You need to log in before you can comment on or make changes to this bug.