Don't upload buildbot server logs to the latest-*-l10n directories

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
4 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Currently the l10n nightly repack build logs are updated to the latest-*-l10n directories, however if you look in the latest-* directories for the en-US files, there are no log files.

Given that and the fact the log files for the l10n nightly repacks are located in the dated directories, we shouldn't be uploading the buildbot logs to the latest-*-l10n directories.
(Assignee)

Comment 1

6 years ago
Created attachment 677534 [details] [diff] [review]
Possible fix

Ok, so bug 605904 decided not to release en-US to latest because we didn't have a good way of tidying them up.

Bug 635486 then implemented log uploading for l10n builds, but didn't follow the disabling that en-US already had.

Unless there's some really good reason, there's no easy way to tie a log to a specific build, so I think we just shouldn't upload the logs to latest-*. If you need to find the log, you can go into the dated directory.

So this patch disables for l10n and adds an appropriate comment.
Attachment #677534 - Flags: review?(catlee)
Comment on attachment 677534 [details] [diff] [review]
Possible fix

Review of attachment 677534 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #677534 - Flags: review?(catlee) → review+
(Assignee)

Updated

6 years ago
Assignee: nobody → mbanner
(In reply to Nick Thomas [:nthomas] from comment #3)
> Deployment docs:
>  https://wiki.mozilla.org/ReleaseEngineering/How_To/Modify_scripts_on_stage

Disregard this as the change isn't to post_upload.py. Possibly this gets deployed when we reconfig the masters.
(In reply to Nick Thomas [:nthomas] from comment #5) 
> Disregard this as the change isn't to post_upload.py. Possibly this gets
> deployed when we reconfig the masters.

OK, that was the consensus here too.

I've updated the buildbotcustom checkouts on all the buildbot masters. That *should* be sufficient for this change.
(Assignee)

Comment 7

6 years ago
Either this hasn't deployed right, or there's still an issue:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-central-l10n/

has logs from:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2012-11-13-03-02-57-comm-central-l10n/

which was today's nightlies.

(Could we also empty out all the log files from the various latest-*-l10n directories to aid checking this?)
(In reply to Mark Banner (:standard8) from comment #8)
> I'm pretty sure this has worked today, at least for the Thunderbird linux64
> nightlies. Can we get the old log files removed from ftp?

Sure, I'll take care of it.
(In reply to Chris Cooper [:coop] from comment #9)
> (In reply to Mark Banner (:standard8) from comment #8)
> > I'm pretty sure this has worked today, at least for the Thunderbird linux64
> > nightlies. Can we get the old log files removed from ftp?
> 
> Sure, I'll take care of it.

This is done now.
(Assignee)

Comment 11

6 years ago
Thanks, I'll confirm this tomorrow.
(Assignee)

Comment 12

6 years ago
No log files have appeared today in the latest-* directories, but they are still in the dated *-l10n directories, so this is fixed now :-)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Created attachment 692227 [details] [diff] [review]
[svn] remove cron cleanup

Removes the jobs that are no longer needed now that we aren't putting l10n logs in latest dirs, and the exclusions in jobs we want to keep.
Attachment #692227 - Flags: review?(catlee)

Updated

6 years ago
Attachment #692227 - Flags: review?(catlee) → review+
Comment on attachment 692227 [details] [diff] [review]
[svn] remove cron cleanup

Transmitting file data ..
Committed revision 54584.
Attachment #692227 - Flags: checked-in+
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.