Closed Bug 807783 Opened 7 years ago Closed 7 years ago

[WebAPI] WebSMS: Develop tests to verify filtering SMS messages by delivery (sent/received)

Categories

(Core :: DOM: Device Interfaces, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: rwood, Assigned: rwood)

References

Details

Attachments

(1 file)

Develop new WebAPI (emulator) tests to verify MozSmsFilter.delivery (via sms.getMessages).
Blocks: 794562
Attached patch Patch for 807783Splinter Review
Attachment #678892 - Flags: feedback?(vyang)
Comment on attachment 678892 [details] [diff] [review]
Patch for 807783

Review of attachment 678892 [details] [diff] [review]:
-----------------------------------------------------------------

I think you can have one test_filter_delivery_state.js instead by sending a message to emulator itself. And then you can merge test cases for same API/attribute into one test script.
Attachment #678892 - Flags: feedback?(vyang)
Hi Vicamo,

I appreciate your feedback however I prefer to keep these two tests separate as they are testing two different test cases.  If you could please give me a feedback+ as I need to get these tests into TBPL ASAP.  Thanks!

Rob
Comment on attachment 678892 [details] [diff] [review]
Patch for 807783

Moving to next stage.
Attachment #678892 - Flags: review?(jgriffin)
Attachment #678892 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/0c22f08662e0
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.