Closed
Bug 807783
Opened 13 years ago
Closed 13 years ago
[WebAPI] WebSMS: Develop tests to verify filtering SMS messages by delivery (sent/received)
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: rwood, Assigned: rwood)
References
Details
Attachments
(1 file)
|
15.12 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
Develop new WebAPI (emulator) tests to verify MozSmsFilter.delivery (via sms.getMessages).
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #678892 -
Flags: feedback?(vyang)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 678892 [details] [diff] [review]
Patch for 807783
Review of attachment 678892 [details] [diff] [review]:
-----------------------------------------------------------------
I think you can have one test_filter_delivery_state.js instead by sending a message to emulator itself. And then you can merge test cases for same API/attribute into one test script.
Attachment #678892 -
Flags: feedback?(vyang)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Hi Vicamo,
I appreciate your feedback however I prefer to keep these two tests separate as they are testing two different test cases. If you could please give me a feedback+ as I need to get these tests into TBPL ASAP. Thanks!
Rob
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 678892 [details] [diff] [review]
Patch for 807783
Moving to next stage.
Attachment #678892 -
Flags: review?(jgriffin)
|
||
Updated•13 years ago
|
Attachment #678892 -
Flags: review?(jgriffin) → review+
|
|
||
Comment 5•13 years ago
|
||
Whiteboard: [automation-needed-in-aurora]
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
|
|
||
Comment 7•13 years ago
|
||
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Whiteboard: [automation-needed-in-aurora]
You need to log in
before you can comment on or make changes to this bug.
Description
•