Add a memory reporter for the nsScriptNameSpaceManager

RESOLVED FIXED in Firefox 18

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla19
Points:
---

Firefox Tracking Flags

(firefox18 fixed, firefox19 fixed)

Details

(Whiteboard: [MemShrink])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is one of the bigger single chunks remaining, and it shows up in every
process on B2G.
(Assignee)

Comment 1

5 years ago
Created attachment 677608 [details] [diff] [review]
Add a memory reporter for the nsScriptNameSpaceManager.

Pretty straightforward.  On 64-bit builds it's 153 KiB per process, and
probably a bit less on 32-bit.
Attachment #677608 - Flags: review?(jst)
(Assignee)

Updated

5 years ago
Blocks: 798484
Whiteboard: [MemShrink]
(Assignee)

Comment 2

5 years ago
> Pretty straightforward.  On 64-bit builds it's 153 KiB per process, and
> probably a bit less on 32-bit.

For the main process that is ~0.5% of the heap, for child processes it's ~1%.

Updated

5 years ago
Attachment #677608 - Flags: review?(jst) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5775d8c498
(Assignee)

Comment 4

5 years ago
Comment on attachment 677608 [details] [diff] [review]
Add a memory reporter for the nsScriptNameSpaceManager.

[Approval Request Comment]

Bug caused by (feature/regressing bug #):  N/A.

User impact if declined:  less understanding of B2G memory consumption.

Testing completed (on m-c, etc.):  just landed on m-c.

Risk to taking this patch (and alternatives if risky):  minimal.  Code is only run when viewing about:memory or triggering a memory report dump.

String or UUID changes made by this patch:  none.
Attachment #677608 - Flags: approval-mozilla-aurora?

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5a5775d8c498
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19

Updated

5 years ago
Attachment #677608 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/8ae22fe748fc
status-firefox18: --- → fixed
status-firefox19: --- → fixed
Can someone please attach a testcase ?
You need to log in before you can comment on or make changes to this bug.