807884 - Add memory reporters for nsComponentManager and nsCategoryManager

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

nsComponentManager and nsCategoryManager account for a moderate amount of memory in each B2G process.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove dead nsComponentManagerImpl::mLoaderData.

Simple dead code removal.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Add memory reporters for nsComponentManager and nsCategoryManager.

These reporters account for about 270 KiB per process on 64-bit builds.

Comment 3

[Nicholas Nethercote [inactive]]

Review ping.  Getting "heap-unclassified" down is quite important for B2G, and this is one of the larger pieces left.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47b21acef98e
https://hg.mozilla.org/integration/mozilla-inbound/rev/74a7026fff15

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/47b21acef98e
https://hg.mozilla.org/mozilla-central/rev/74a7026fff15

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 677646 [details] [diff] [review]
(part 1) - Remove dead nsComponentManagerImpl::mLoaderData.

[Approval Request Comment]

Bug caused by (feature/regressing bug #):  N/A.

User impact if declined:  prevents the next patch from applying.

Testing completed (on m-c, etc.):  been on m-c for several days without problem.

Risk to taking this patch (and alternatives if risky):  negligible;  it's trivial dead code removal.

String or UUID changes made by this patch:  none.

Comment 7

[Nicholas Nethercote [inactive]]

Comment on attachment 677647 [details] [diff] [review]
(part 2) - Add memory reporters for nsComponentManager and nsCategoryManager.

[Approval Request Comment]

Bug caused by (feature/regressing bug #):  N/A.

User impact if declined:  less understanding of B2G memory consumption.

Testing completed (on m-c, etc.):  been on m-c for several days.

Risk to taking this patch (and alternatives if risky):  low.  The code is only run when about:memory is viewed or a memory reporter dump is triggered.

String or UUID changes made by this patch:  none.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f5f84571a165
https://hg.mozilla.org/releases/mozilla-aurora/rev/8947bfd8f678