Closed Bug 807884 Opened 12 years ago Closed 12 years ago

Add memory reporters for nsComponentManager and nsCategoryManager

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Whiteboard: [MemShrink])

Attachments

(2 files)

nsComponentManager and nsCategoryManager account for a moderate amount of memory in each B2G process.
Simple dead code removal.
Attachment #677646 - Flags: review?(benjamin)
These reporters account for about 270 KiB per process on 64-bit builds.
Attachment #677647 - Flags: review?(benjamin)
Review ping. Getting "heap-unclassified" down is quite important for B2G, and this is one of the larger pieces left.
Attachment #677646 - Flags: review?(benjamin) → review+
Attachment #677647 - Flags: review?(benjamin) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment on attachment 677646 [details] [diff] [review] (part 1) - Remove dead nsComponentManagerImpl::mLoaderData. [Approval Request Comment] Bug caused by (feature/regressing bug #): N/A. User impact if declined: prevents the next patch from applying. Testing completed (on m-c, etc.): been on m-c for several days without problem. Risk to taking this patch (and alternatives if risky): negligible; it's trivial dead code removal. String or UUID changes made by this patch: none.
Attachment #677646 - Flags: approval-mozilla-aurora?
Comment on attachment 677647 [details] [diff] [review] (part 2) - Add memory reporters for nsComponentManager and nsCategoryManager. [Approval Request Comment] Bug caused by (feature/regressing bug #): N/A. User impact if declined: less understanding of B2G memory consumption. Testing completed (on m-c, etc.): been on m-c for several days. Risk to taking this patch (and alternatives if risky): low. The code is only run when about:memory is viewed or a memory reporter dump is triggered. String or UUID changes made by this patch: none.
Attachment #677647 - Flags: approval-mozilla-aurora?
Attachment #677646 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #677647 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: