807919 - stop invalidating text bounds twice on updates

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

Attachment: patch

Comment 1

[Robert Longson [:longsonr]]

nsSVGTextFrame::ReflowSVG calls nsSVGTextFrameBase::ReflowSVG which is nsSVGDisplayContainerFrame::ReflowSVG and that looks like this...

http://hg.mozilla.org/mozilla-central/file/d16c4404e8c4/layout/svg/base/src/nsSVGContainerFrame.cpp#l305

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 677692 [details] [diff] [review]
patch

Bug 802628 will make this redundant, and this may rot bug 655877, but I guess not too big a deal for either so r=jwatt.

In place of the first block you're removing can you add something like:

  // We leave it up to nsSVGTextFrameBase::ReflowSVG to invalidate. XXXSDL

Comment 3

[Robert Longson [:longsonr]]

Originally sent to try as part of a larger patch. Here's the result:

https://tbpl.mozilla.org/?tree=Try&rev=d6d2fcbae0ef

Comment 4

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce61b65cbf9b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ce61b65cbf9b