807936 - Add a configure flag to support running cross-compiled shells under qemu

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Marty Rosenberg [:mjrosenb]]

Attachment: /home/mrosenberg/patches/qemuuu-r0.patch

This patch enables cross compiled js shell and jsapi-test shell to both run under qemu with minimal user intervention.  I was able to run make && make check to run our testsuite on an emulated shell.

Comment 1

[(not currently active) Ted Mielczarek]

I'll review this shortly. This is interesting, and a good first step, but I think the longer-term goal should be to refactor the JS test harnesses so that they have more flexibility in execution, so that running under QEMU or on a mobile device are both straightforward. (We support the latter in all of our other test harnesses, it's a pretty glaring omission in the JS tests right now.)

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 677706 [details] [diff] [review]
/home/mrosenberg/patches/qemuuu-r0.patch

Review of attachment 677706 [details] [diff] [review]:
-----------------------------------------------------------------

Overall this seems okay. I'd like to get a bug on file for making all the JS tests runnable on devices as well. I think if we fix that we could subsume running under an emulator as a special case.

::: js/src/build/qemu-wrap
@@ +10,5 @@
> +        --ld) LD="$2"; shift 2;;
> +        *) exe="$1"; shift;;
> +    esac
> +done
> +LD=${LD:-$LIBDIR/ld-linux.so.3}

You don't actually check that LIBDIR is set here.

::: js/src/configure.in
@@ +4159,5 @@
> +dnl ========================================================
> +
> +MOZ_ARG_WITH_STRING(qemu-cross,
> +[  --with-qemu-cross=path   Use path as an arm emulator on host platforms],
> +    QEMU_EXE=$withval)

"qemu-cross" doesn't make a lot of sense as an argument name to me. You're calling it QEMU_EXE here, so why not --with-qemu-exe?

@@ +4164,5 @@
> +AC_SUBST(QEMU_EXE)
> +MOZ_ARG_WITH_STRING(cross-lib,
> +[  --with-cross-lib=dir   Use dir as the location for arm libraries],
> +    CROSS_LIB=$withval,
> +    CROSS_LIB=/usr/$target)

Is this a reasonable default? (I don't actually know.)

Comment 3

[Marty Rosenberg [:mjrosenb]]

Attachment: qemu patch, revision 1

Nits have been fixed.

Comment 4

[Phil Ringnalda (:philor)]

Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/77972f22952a for check-sync-dirs.py bustage.

Comment 5

[Marty Rosenberg [:mjrosenb]]

re-landed with an extra file.  Looks green on try (I am not expecting any change in behavior on any test due to this patch)

https://tbpl.mozilla.org/?tree=Try&rev=3001674f6fd0

Landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a53df18c076

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1a53df18c076