808002 - nsIDOMDataChannel.reliable is a lie

Status: VERIFIED FIXED

(Core :: WebRTC, defect)

Description

[(not currently active) Ted Mielczarek]

The .reliable property of nsIDOMDataChannel doesn't reflect reality. If I create a DataChannel like:
pc.createDataChannel("unreliable", {outOfOrderAllowed: true, maxRetransmitNum: 0});

it still returns true, even though this is as unreliable as you can make a DataChannel (out-of-order delivery, no retransmit).

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: add missing consts lost in main landing for unreliable data channels

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 677902 [details] [diff] [review]
add missing consts lost in main landing for unreliable data channels

The consts used to communicate from JS to C++ got lost in the merge from alder, and with the error console gone I didn't notice (since the default is reliable).

Comment 3

[Anant Narayanan [:anant]]

Comment on attachment 677902 [details] [diff] [review]
add missing consts lost in main landing for unreliable data channels

Review of attachment 677902 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but it might be better to use the 'kConstant' form for consistency with the other consts.

Comment 4

[Anant Narayanan [:anant]]

Also, nit: space between the "=" ;)

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: add missing consts lost in main landing for unreliable data channels

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 679131 [details] [diff] [review]
add missing consts lost in main landing for unreliable data channels

Quick re-review; match normal style

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7641c574455b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7641c574455b

Comment 9

[Jason Smith [:jsmith]]

Verified with a test case modeling the STR given in comment 0 with unreliable channel and checking it's reliable property.