Closed Bug 808002 Opened 8 years ago Closed 8 years ago

nsIDOMDataChannel.reliable is a lie

Categories

(Core :: WebRTC, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla19
Tracking Status
firefox18 --- wontfix

People

(Reporter: ted, Assigned: jesup)

Details

Attachments

(1 file, 1 obsolete file)

The .reliable property of nsIDOMDataChannel doesn't reflect reality. If I create a DataChannel like:
pc.createDataChannel("unreliable", {outOfOrderAllowed: true, maxRetransmitNum: 0});

it still returns true, even though this is as unreliable as you can make a DataChannel (out-of-order delivery, no retransmit).
Comment on attachment 677902 [details] [diff] [review]
add missing consts lost in main landing for unreliable data channels

The consts used to communicate from JS to C++ got lost in the merge from alder, and with the error console gone I didn't notice (since the default is reliable).
Attachment #677902 - Flags: review?(anant)
Assignee: nobody → rjesup
Comment on attachment 677902 [details] [diff] [review]
add missing consts lost in main landing for unreliable data channels

Review of attachment 677902 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but it might be better to use the 'kConstant' form for consistency with the other consts.
Attachment #677902 - Flags: review?(anant) → review+
Also, nit: space between the "=" ;)
Attachment #677902 - Attachment is obsolete: true
Comment on attachment 679131 [details] [diff] [review]
add missing consts lost in main landing for unreliable data channels

Quick re-review; match normal style
Attachment #679131 - Flags: review?(anant)
Attachment #679131 - Flags: review?(anant) → review+
https://hg.mozilla.org/mozilla-central/rev/7641c574455b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Keywords: verifyme
Flags: in-testsuite?
Verified with a test case modeling the STR given in comment 0 with unreliable channel and checking it's reliable property.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.