Closed
Bug 808106
Opened 12 years ago
Closed 12 years ago
[WebAPI] WebSMS: Develop tests to verify filtering SMS messages by date
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: rwood, Assigned: rwood)
References
Details
Attachments
(1 file)
12.39 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
Develop new WebAPI (emulator) tests to verify MozSmsFilter.startDate and MozSmsFilter.endDate (via sms.getMessages).
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #679001 -
Flags: feedback?(vyang)
Comment 2•12 years ago
|
||
Comment on attachment 679001 [details] [diff] [review] Patch for 808106 Review of attachment 679001 [details] [diff] [review]: ----------------------------------------------------------------- Hi Rob, could you merge the two test scripts? They're mostly the same actually.
Attachment #679001 -
Flags: feedback?(vyang)
Assignee | ||
Comment 3•12 years ago
|
||
Vicamo, Thanks for your feedback however I prefer to keep different test cases in separate tests. This keeps tests simpler, easier to debug failures, and easier to maintain. Please give me a feedback+ so I can move on to the next step and have the test reviewed. I need to get these on TBPL ASAP. Thanks! Rob
Comment 4•12 years ago
|
||
(In reply to Rob Wood [:rwood] from comment #3) > Please give me a feedback+ so I can move on to the next step and have the test > reviewed. I can't. The two files have almost 4/5 duplicated code, only a few lines in getMsgs() are different.
Comment 5•12 years ago
|
||
What we need here is bug 805838 being solved. It would allow us to have modules with common code similar to Mochitests. Right now that's not possible. And I think it will improve things a lot. I did a quick check to the tests and I would prefer if we could have a bit of documentation comments. That would make it easier for everyone to check what's being tested in each method.
Assignee | ||
Comment 6•12 years ago
|
||
Yep, once we can use common modules the amount of code repetition between tests will be greatly reduced. When that option is available I can revisit some of my tests and streamline them, however for now it is important to get the tests on TBPL ASAP, so moving along to the next step.
Assignee | ||
Updated•12 years ago
|
Attachment #679001 -
Flags: review?(jgriffin)
Comment 7•12 years ago
|
||
(In reply to Rob Wood [:rwood] from comment #6) > It is important to get the tests on TBPL ASAP, so moving along to the next step. I really don't know why you open new bugs to block a really important one. There are already marionette test cases for SMS, mochitest and xpcshell tests as well. So why do we block on a new, unrevised test case now?
Assignee | ||
Comment 8•12 years ago
|
||
I really don't understand what you mean Vicamo. Nothing is blocked. The tests are under review. 794562 mentioned above is just a tracking bug for all the related tests.
Updated•12 years ago
|
Attachment #679001 -
Flags: review?(jgriffin) → review+
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/35c328e03795
Whiteboard: [automation-needed-in-aurora][automation-needed-in-beta]
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/35c328e03795
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment 11•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/dab7ec84d88c https://hg.mozilla.org/releases/mozilla-beta/rev/8f0032f48497
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
status-firefox20:
--- → fixed
Whiteboard: [automation-needed-in-aurora][automation-needed-in-beta]
You need to log in
before you can comment on or make changes to this bug.
Description
•