808106 - [WebAPI] WebSMS: Develop tests to verify filtering SMS messages by date

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Robert Wood [:rwood]]

Develop new WebAPI (emulator) tests to verify MozSmsFilter.startDate and MozSmsFilter.endDate (via sms.getMessages).

Comment 1

[Robert Wood [:rwood]]

Attachment: Patch for 808106

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 679001 [details] [diff] [review]
Patch for 808106

Review of attachment 679001 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Rob, could you merge the two test scripts? They're mostly the same actually.

Comment 3

[Robert Wood [:rwood]]

Vicamo,

Thanks for your feedback however I prefer to keep different test cases in separate tests.  This keeps tests simpler, easier to debug failures, and easier to maintain.  Please give me a feedback+ so I can move on to the next step and have the test reviewed.  I need to get these on TBPL ASAP.  Thanks!

Rob

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Rob Wood [:rwood] from comment #3)
> Please give me a feedback+ so I can move on to the next step and have the test
> reviewed.

I can't. The two files have almost 4/5 duplicated code, only a few lines in getMsgs() are different.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

What we need here is bug 805838 being solved. It would allow us to have modules with common code similar to Mochitests. Right now that's not possible. And I think it will improve things a lot.

I did a quick check to the tests and I would prefer if we could have a bit of documentation comments. That would make it easier for everyone to check what's being tested in each method.

Comment 6

[Robert Wood [:rwood]]

Yep, once we can use common modules the amount of code repetition between tests will be greatly reduced.  When that option is available I can revisit some of my tests and streamline them, however for now it is important to get the tests on TBPL ASAP, so moving along to the next step.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Rob Wood [:rwood] from comment #6)
> It is important to get the tests on TBPL ASAP, so moving along to the next step.

I really don't know why you open new bugs to block a really important one. There are already marionette test cases for SMS, mochitest and xpcshell tests as well. So why do we block on a new, unrevised test case now?

Comment 8

[Robert Wood [:rwood]]

I really don't understand what you mean Vicamo.  Nothing is blocked. The tests are under review. 794562 mentioned above is just a tracking bug for all the related tests.

Comment 9

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35c328e03795

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/35c328e03795

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dab7ec84d88c
https://hg.mozilla.org/releases/mozilla-beta/rev/8f0032f48497