808176 - devtools.chrome.enabled=true should also show the Error Console menuitem

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

See this patch for the change that only made these menuitems show up if devtools.errorconsole.enabled was set to true. We should check for either devtools.errorconsole.enabled=true or if devtools.chrome.enabled=true: 

https://bug602006.bugzilla.mozilla.org/attachment.cgi?id=632136

Comment 1

[bhavana bajaj [:bajaj]]

Jared, this looks more of a feature change & not a regression. Why is this needed on FF18 specifically ?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

The patch for bug 602006 landed in 18 and we've received feedback from developers that they were a little confused as to why the menuitem was missing and how to get it visible again.

The required work for this bug is very minimal and there is no risk anticipated, while the potential win from this change may help to make things clearer since we can just tell Gecko & add-on developers to set a single pref for when they are working on the browser chrome.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 4

[bhavana bajaj [:bajaj]]

Jaws, If I am interpreting it right, this patch would address the last few comments in Bug 798925 & would resolve that bug fixed if uplifted ?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

It's not a perfect solution and doesn't resolve that bug when uplifted, but it does make the situation a little better.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86dcbe46c097

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 678951 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): no bug, but due to bug 
User impact if declined: better usability for addon & gecko devs
Testing completed (on m-c, etc.): just landed on m-i, trivial patch
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Sorry, I forgot to finish the first question.
Bug caused by (feature/regressing bug #): no bug, but due to bug 602006 some addon/gecko developers may not see the Error Console menuitem, but they may already have flipped this preference, so landing this change will reduce confusion for those users.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/86dcbe46c097

Comment 10

[bhavana bajaj [:bajaj]]

This does nor require tracking for release, but approving the needed aurora uplift .

Comment 11

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6735d6d13751