808193 - [bluetooth] pairing crashes both phones

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dietrich Ayala (:dietrich)]

trying to pair unagi and otoro causes them both to crash.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Broken feature, bb+.  Please kick this off as you see fit Kyle.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Repro'd.

Repro:

1. Bring up settings app
2. Go to bluetooth screen
3. Let bluetooth discover a device
4. Click on it

Expected:

Pairing dialog comes up

Actual:

Crash

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

In release mode, there's nothing interesting in the logcat. However, in debug mode, we get something rather freaky:

I/Gonk    ( 1304): log_and_free_dbus_error: D-Bus error: org.freedesktop.DBus.Error.UnknownMethod (Method "GetProperties" with signature "" on interface "org.bluez.Device" doesn't exist
I/Gonk    ( 1304): )

That happens the first time I hit the pair button. I get no pairing dialog. That's assumed to be a failure, so I hit pair again, at which time it actually crashes. Here's the crash stack there:

0x40b4cc56 in EqualsLiteral<7> (aConn=<value optimized out>, aMsg=0x4abdd310, aData=<value optimized out>) at ../../dist/include/nsTSubstring.h:292
292               return EqualsASCII(str, N-1);
(gdb) bt
#0  0x40b4cc56 in EqualsLiteral<7> (aConn=<value optimized out>, aMsg=0x4abdd310, aData=<value optimized out>) at ../../dist/include/nsTSubstring.h:292
#1  EventFilter (aConn=<value optimized out>, aMsg=0x4abdd310, aData=<value optimized out>) at /share/code/mozbuild/B2G/gecko/dom/bluetooth/linux/BluetoothDBusService.cpp:1372
#2  0x41f27334 in dbus_connection_dispatch (connection=0x479b85c0) at external/dbus/dbus/dbus-connection.c:4679
#3  0x40ea5be4 in mozilla::ipc::DBusThread::EventLoop (this=0x42646560) at /share/code/mozbuild/B2G/gecko/ipc/dbus/DBusThread.cpp:392
#4  0x4071d510 in nsRunnableMethodImpl<void (nsPACMan::*)(), true>::Run (this=<value optimized out>) at ../../../dist/include/nsThreadUtils.h:350
#5  0x40ec9cfa in nsThread::ProcessNextEvent (this=0x46e84880, mayWait=<value optimized out>, result=0x47bffeb7) at /share/code/mozbuild/B2G/gecko/xpcom/threads/nsThread.cpp:627
#6  0x40eaa44e in NS_ProcessNextEvent_P (thread=0x47bff7f8, mayWait=true) at /share/code/mozbuild/B2G/objdir-gecko/xpcom/build/nsThreadUtils.cpp:221
#7  0x40eca144 in nsThread::ThreadFunc (arg=<value optimized out>) at /share/code/mozbuild/B2G/gecko/xpcom/threads/nsThread.cpp:265
#8  0x40235980 in _pt_root (arg=<value optimized out>) at /share/code/mozbuild/B2G/gecko/nsprpub/pr/src/pthreads/ptthread.c:156
#9  0x40051e18 in __thread_entry (func=0x40235921 <_pt_root>, arg=0x470b8470, tls=<value optimized out>) at bionic/libc/bionic/pthread.c:217
#10 0x4005196c in pthread_create (thread_out=<value optimized out>, attr=0x47affd0c, start_routine=0x40235921 <_pt_root>, arg=0x470b8470) at bionic/libc/bionic/pthread.c:357
#11 0x00000000 in ?? ()
(gdb) 

It's crashing on a comparison to a string that doesn't even exist, because we never checked the length of the array we got back that should contain the string (we need to get the dbus fuzzer in bug 780748 going ASAP).

So it can't get the properties on the device or something? I suspect one of two culprits. We changed versions of bluetooth stuff on the device again, or else the property stuff I checked in as part of bug 802428 bombs on pairing for some reason.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: return 'boolean' once PROP_DEVICE_CONNECTED_TYPE is not found

The root cause of this issue is because PROP_DEVICE_CONNECTED_TYPE is not defined, so the return value of function IsDeviceConnectedTypeBoolean() will be false even if the it's really a Boolean variable.

Comment 5

[Eric Chou [:ericchou] [:echou]]

direcly checked into m-c since it breaks the pairing function of Bluetooth:

https://hg.mozilla.org/mozilla-central/rev/f9c2c266e7aa

Comment 6

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2b0ab957d9da