808216 - [settings] Screen flashes white before displaying settings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Marcia Knous [:marcia]]

unagi device, using

Gecko - deb877e25babdfc5baf53108b67a25efd3e29ef2
Gaia - 4cfe5cac3f1b7f25519d5611ac3e1d832544b0d1 

STR:
1. Load settings
2. Observe a white flash which happens after loading.

Similar bugs: Bug 805979 and 799747

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7811

With this patch the app does not flicker on cold boot when transitioning between screenshot and the actual screen because:

 - translations are disabled on init
 - I reordered the CSS so that uninit class takes precedence over normal behavior

Comment 2

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/6677c14cddb808f7405342c4a104cd4a6867e386

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Last time we fixed this bug it was a big improvement on startup time.  Did anyone measure before/after this patch?

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

So, uh, yeah

before:
 (white flash) 2.41, 2.38, 2.35
     (full UI) 2.97, 3.03, 3.03

after:
 1.88, 1.88, 1.94

This patch is over a 1 second win on showing real UI.

Can we get this uplifted Right The Fuck Soon now?

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(testing on unmodified v1-train
$ (cd gecko/ && git rev-parse HEAD && cd ../gaia && git rev-parse HEAD)
cedbc43dfa7602f37ba451d2bdb6c3536fea823b
d6595fbdd9cd8de0c169be57bc11aaebc1849dd7
)

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

It's unclear where this might have been uplifted, so please update the status-b2g18 and status-b2g18-v1.0.0 flags to fixed once this is verified to be on v1-train and v1.0.0 branches.

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

See comment 5: not on v1-train, so presumably not on v1.0.0.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 7160d160a570bd3d328260c36039b7f2d747bc1b
v1.0.0: 6ce3d3853c97dcd52e15d2ea074480ac8df5bb87

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

\o/

Comment 11

[mdaniloff]

Issue still reproduces in:

UnagiBuild ID: 20130215070202
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/a9e4f8912607 Gaia   21ba59d933c66024cb351c2379315301d5352e0c
Update Channel: Nightly


Master build id: 20130215031126
gaia" remote="hgmozillaorg" revision="e59a3e9a924b"/> 
gecko" remote="hgmozillaorg" revision="953b1db7a246"/>

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

as noted in https://bugzilla.mozilla.org/show_bug.cgi?id=808216#c4; the white flash is shorter.  In that regards this bug is verified fixed for 

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/778da49486f0
Gaia   6c3767c2dea43b5e9aff7d156d36d69649005621
BuildID 20130320070206
Version 18.0

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e74dafa6b2d9
Gaia   1438da6ca0e020a8df686e2100a668370dfe6fb6
BuildID 20130312230202
Version 18.0