Closed Bug 808294 Opened 8 years ago Closed 8 years ago

Fix tracelogger builds after yarr update

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: h4writer, Assigned: h4writer)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
Since the yarr update the tracelogger builds won't build anymore:

In file included from ../vm/RegExpObject.h:21:0,
                 from ../jscompartment.h:21,
                 from /home/h4writer/Build/mozilla-inbound/js/src/ion/Ion.h:12,
                 from /home/h4writer/Build/mozilla-inbound/js/src/jscntxt.cpp:45:
../yarr/YarrJIT.h: In member function ‘MatchResult JSC::Yarr::YarrCodeBlock::execute(const UChar*, unsigned int, unsigned int, int*)’:
../yarr/YarrJIT.h:129:33: error: ‘YARR_JIT_START’ is not a member of ‘js::TraceLogging’
../yarr/YarrJIT.h:130:33: error: ‘YARR_JIT_STOP’ is not a member of ‘js::TraceLogging’
../yarr/YarrJIT.h: In member function ‘MatchResult JSC::Yarr::YarrCodeBlock::execute(const UChar*, unsigned int, unsigned int)’:
../yarr/YarrJIT.h:143:33: error: ‘YARR_JIT_START’ is not a member of ‘js::TraceLogging’
../yarr/YarrJIT.h:144:33: error: ‘YARR_JIT_STOP’ is not a member of ‘js::TraceLogging’
Attachment #678013 - Attachment is patch: true
Attachment #678013 - Flags: review?(dvander)
Blocks: 740015
Attached patch PatchSplinter Review
Forgot to qref
Assignee: general → hv1989
Attachment #678013 - Attachment is obsolete: true
Attachment #678013 - Flags: review?(dvander)
Attachment #678017 - Flags: review?(dvander)
Attachment #678017 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/041c8232bdcb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.