808296 - java.lang.NullPointerException: at org.mozilla.gecko.AboutHomeContent.updateTopSitesThumbnails(AboutHomeContent.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There's one crash in 19.0a1/20121103: bp-213e81d6-e19c-438f-8a42-25ee42121103.
It might be a regression from bug 785945.

java.lang.NullPointerException
	at org.mozilla.gecko.AboutHomeContent.updateTopSitesThumbnails(AboutHomeContent.java:335)
	at org.mozilla.gecko.AboutHomeContent.access$500(AboutHomeContent.java:72)
	at org.mozilla.gecko.AboutHomeContent$8.onPostExecute(AboutHomeContent.java:383)
	at org.mozilla.gecko.AboutHomeContent$8.onPostExecute(AboutHomeContent.java:375)
	at org.mozilla.gecko.util.GeckoAsyncTask$BackgroundTaskRunnable$1.run(GeckoAsyncTask.java:37)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4424)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.AboutHomeContent.updateTopSitesThumbnails%28AboutHomeContent.java%29

Comment 2

[Lucas Rocha (:lucasr)]

Need steps to reproduce this.

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Update top sites thumbnails from adapter, not from gridview

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 678686 [details] [diff] [review]
Update top sites thumbnails from adapter, not from gridview

This does seem more correct. When the grid is out of sync, do we still update the child view at some point? The patch will just continue to the next thumbnail.

Comment 5

[Scoobidiver (away)]

It's #1 top crasher in 19.0a1.

Comment 6

[Lucas Rocha (:lucasr)]

My patch probably fixes this bug. However, given that I couldn't reproduce this locally, I'm not entirely sure it won't cause any side effects due to unexpected races between the adapter and the grid view. It works fine on my devices so I still think my patch is our best bet for now though. Pushing to see how it goes.

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/edc00669b8e1

Comment 7

[Brian Nicholson (:bnicholson)]

This is easily reproducible for me if I do Clear Private Data in the Android settings. If there's at least one top site with a screenshot thumbnail on about:home, it will crash.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/edc00669b8e1