808401 - View Source: pressing home key does not update status bar

Status: NEW

(Toolkit :: View Source, defect)

Description

[Cheng Sun]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/19.0 Firefox/19.0
Build ID: 20121104030714

Steps to reproduce:

View page source. Move to the middle of a line. Press home.


Actual results:

The cursor moves to the beginning of the line as expected. However, the status bar still says the position of the cursor before it moved (e.g. Line 1 Col 10). Also, pressing the right key once has no effect, as if the cursor were at one character before the start of the line.


Expected results:

After pressing home, the status bar should say Line 1 Col 1.
Pressing the right key should move it to Line 1 Col 2.

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/6e219763ddd0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111101 Firefox/10.0a1 ID:20111101052615
Bad:
http://hg.mozilla.org/mozilla-central/rev/cd9add22f090
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111101 Firefox/10.0a1 ID:20111101073309
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6e219763ddd0&tochange=cd9add22f090


Regression window(m-c)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/746e7c151de2
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111101 Firefox/10.0a1 ID:20111101015315
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d9cc2539a85d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111031 Firefox/10.0a1 ID:20111101043415
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=746e7c151de2&tochange=d9cc2539a85d

Suspected Bug 482921

Comment 2

[Alice0775 White]

There are 2 regression window:
#1 : This happens on Last line only  --- regressed by Bug 482921
#2 : It was more worse than #1. This problem happens on any line  --- regressed By Bug 246620

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/a8be91348c31
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20111227 Firefox/12.0a1 ID:20111227102618
Bad:
http://hg.mozilla.org/mozilla-central/rev/7e28cce342a6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20111226 Firefox/12.0a1 ID:20111227110718
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a8be91348c31&tochange=7e28cce342a6

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/966b11b4940d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20111227 Firefox/12.0a1 ID:20111227023024
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/e20ed47b03f2
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20111226 Firefox/12.0a1 ID:20111227042818
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=966b11b4940d&tochange=e20ed47b03f2

Suspected: Bug 246620

Comment 3

[Henri Sivonen (:hsivonen)]

Maybe disabling user selection in a pseudo-element confuses the selection code for the real element, too? The status bar updating is based on listening to changes to the selection.

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/viewsource/content/viewSource.js#42
https://hg.mozilla.org/mozilla-central/rev/02b3a12aea70

Comment 4

[Henri Sivonen (:hsivonen)]

Or maybe pressing home moves the selection to the pseudo-element and the selection isn’t updated because the pseudo-element content has been marked unselectable?

Comment 5

[Graeme McCutcheon [:graememcc]]

We're failing here: http://hg.mozilla.org/mozilla-central/file/561d6a3c4d7b/toolkit/components/viewsource/content/viewSource.js#l505

selection.focusNode is the outer span element which contains the <span>(s) for the line number.
This still happens after removing the -moz-user-select from layout/style/viewsource.css

Comment 6

[(no longer active)]

(In reply to Graeme McCutcheon [:graememcc] from comment #5)
> We're failing here:
> http://hg.mozilla.org/mozilla-central/file/561d6a3c4d7b/toolkit/components/
> viewsource/content/viewSource.js#l505
> 
> selection.focusNode is the outer span element which contains the <span>(s)
> for the line number.
> This still happens after removing the -moz-user-select from
> layout/style/viewsource.css

Hmm, does removing that check fix it?  :-)