808404 - javascript fails on specific page due to defining top level function named 'top'

Status: RESOLVED WORKSFORME

(Tech Evangelism Graveyard :: English US, defect)

Description

[David McDivitt]

Attachment: files.zip, This contains two generated html files, style sheet file, and javascript file

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20100101 Firefox/16.0
Build ID: 20121024073032

Steps to reproduce:

Went to page   http://www.spfldcycling.org/miles/12_08_detail.htm


Actual results:

Javascript does not run on the page and the red "no javascript" message remains at top. Analysis says function "setup()" is not found. The page works fine with Internet Explorer and worked fine with previous Firefox versions. I am not sure exactly which version of Firefox it started to fail. I edited the page trying different things and can't make it work and feel it is a bug introduced in one of the latest Firefox versions.


Expected results:

The red "no javascript" message should disappear. The horizontal and vertical labels should move with the table when scrolled. Clicking on a row should cause that row to change color.

Comment 1

[Loic]

I'm not sure if the bug is valid but there is a regression range. It regressed in FF17 so I guess the regression has been backported into FF16.

m-c
good=2012-08-25
bad=2012-08-26
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f077de66e52d&tochange=b3cce81fef1a

Comment 2

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/116a2c731931
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120825182458
Bad:
http://hg.mozilla.org/mozilla-central/rev/b3cce81fef1a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120826030526
Pushlog;
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=116a2c731931&tochange=b3cce81fef1a


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/7c2aaefc3891
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120825141859
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/573c753b7bc8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120825145758
Pushlog;
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7c2aaefc3891&tochange=573c753b7bc8


Regressed by: Bug 765527
And Bug 765527 maybe uplifted to 16.0

Comment 3

[Andrew McCreight [:mccr8]]

Timestamp: 11/4/12 11:52:27 AM
Error: TypeError: can't redefine non-configurable property 'top'
Source File: http://www.spfldcycling.org/miles/report.js
Line: 67

that file defines a top-level function named 'top'.

Comment 4

[Andrew McCreight [:mccr8]]

This page also fails to work in Chrome 22, but does work in Safari 5.1.7.

Comment 5

[Andrew McCreight [:mccr8]]

Renaming the function 'top' to something else should fix the problem.

Comment 6

[Andrew McCreight [:mccr8]]

Thanks for the report and the regression range!

Comment 7

[David McDivitt]

Thank you for finding an error in my javascript. I updated report.js on the web site and there are no issues with the pages. Too bad I didn't find a bug in Firefox, maybe next time :)

Comment 8

[Andrew McCreight [:mccr8]]

Looks like it is working on Chrome and Firefox now.  Thanks for the update.